Re: [PR] fix: support env-var auth config for REST catalog (JSON string decode + flat properties) [iceberg-python]

["abnobdoss (via GitHub)" <gi...@apache.org>]

abnobdoss commented on code in PR #3423:
URL: https://github.com/apache/iceberg-python/pull/3423#discussion_r3331154116


##########
tests/catalog/test_rest.py:
##########
@@ -3167,3 +3167,135 @@ def test_load_table_without_storage_credentials(
     )
     assert actual.metadata.model_dump() == expected.metadata.model_dump()
     assert actual == expected
+
+
+# Tests for issue #3422: REST catalog auth cannot be configured via environment
+# variables unless auth JSON strings are decoded.
+
+
+def test_rest_catalog_with_basic_auth_as_json_string(rest_mock: Mocker) -> None:

Review Comment:
   Thanks for addressing the comments! I think this change might not have gone through.



##########
tests/catalog/test_rest.py:
##########
@@ -3167,3 +3167,135 @@ def test_load_table_without_storage_credentials(
     )
     assert actual.metadata.model_dump() == expected.metadata.model_dump()
     assert actual == expected
+
+
+# Tests for issue #3422: REST catalog auth cannot be configured via environment
+# variables unless auth JSON strings are decoded.
+
+
+def test_rest_catalog_with_basic_auth_as_json_string(rest_mock: Mocker) -> None:

Review Comment:
   Thanks for addressing the comments! I think the testing change might not have gone through.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org