You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2018/04/26 23:42:54 UTC
Review Request 66838: ATLAS-2620: updated entity-lookup REST API to
use basic-search implementation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66838/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, and Sarath Subramanian.
Bugs: ATLAS-2620
https://issues.apache.org/jira/browse/ATLAS-2620
Repository: atlas
Description
-------
Current implementation of the REST API for entity-lookup was done before basic-search API was introduced. Updated the implementation to use basic-search, which is more efficient.
Diffs
-----
webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java af309a175
Diff: https://reviews.apache.org/r/66838/diff/1/
Testing
-------
- validated in my local deployment
- precommit is in progress - https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/311/
Thanks,
Madhan Neethiraj
Re: Review Request 66838: ATLAS-2620: updated entity-lookup REST API
to use basic-search implementation
Posted by Madhan Neethiraj <ma...@apache.org>.
> On April 26, 2018, 11:50 p.m., Sarath Subramanian wrote:
> > webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java
> > Lines 286 (patched)
> > <https://reviews.apache.org/r/66838/diff/1/?file=2013418#file2013418line286>
> >
> > StringUtils.isEmpty(attrName) check is not needed here, it already done in line#278
this 'if' handles the case when the given typeName is invalid or the type doesn't have any of the default attributes. In such case, subsequent call to searchWithParameters() will fail with appropriate error code.
- Madhan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66838/#review202041
-----------------------------------------------------------
On April 26, 2018, 11:42 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66838/
> -----------------------------------------------------------
>
> (Updated April 26, 2018, 11:42 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2620
> https://issues.apache.org/jira/browse/ATLAS-2620
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Current implementation of the REST API for entity-lookup was done before basic-search API was introduced. Updated the implementation to use basic-search, which is more efficient.
>
>
> Diffs
> -----
>
> webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java af309a175
>
>
> Diff: https://reviews.apache.org/r/66838/diff/1/
>
>
> Testing
> -------
>
> - validated in my local deployment
> - precommit is in progress - https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/311/
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 66838: ATLAS-2620: updated entity-lookup REST API
to use basic-search implementation
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66838/#review202041
-----------------------------------------------------------
Fix it, then Ship it!
webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java
Lines 286 (patched)
<https://reviews.apache.org/r/66838/#comment283700>
StringUtils.isEmpty(attrName) check is not needed here, it already done in line#278
- Sarath Subramanian
On April 26, 2018, 4:42 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66838/
> -----------------------------------------------------------
>
> (Updated April 26, 2018, 4:42 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2620
> https://issues.apache.org/jira/browse/ATLAS-2620
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Current implementation of the REST API for entity-lookup was done before basic-search API was introduced. Updated the implementation to use basic-search, which is more efficient.
>
>
> Diffs
> -----
>
> webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java af309a175
>
>
> Diff: https://reviews.apache.org/r/66838/diff/1/
>
>
> Testing
> -------
>
> - validated in my local deployment
> - precommit is in progress - https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/311/
>
>
> Thanks,
>
> Madhan Neethiraj
>
>