You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/06 18:52:41 UTC

[GitHub] [arrow-rs] alamb opened a new pull request #528: Remove unused futures dependency from arrow-flight

alamb opened a new pull request #528:
URL: https://github.com/apache/arrow-rs/pull/528


   # Rationale for this change
    
   I am trying to keep the `arrow*` dependency stack minimal and this dependency is only used in the examples
   
   # What changes are included in this PR?
   
   Move dependencies to `[dev-dependencies]`
   
   # Are there any user-facing changes?
   One less dependency on crates.io
   
   <!---
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-rs] alamb commented on pull request #528: Remove unused futures dependency from arrow-flight

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #528:
URL: https://github.com/apache/arrow-rs/pull/528#issuecomment-877182266


   Thanks @nevi-me !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-rs] nevi-me merged pull request #528: Remove unused futures dependency from arrow-flight

Posted by GitBox <gi...@apache.org>.
nevi-me merged pull request #528:
URL: https://github.com/apache/arrow-rs/pull/528


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-rs] codecov-commenter commented on pull request #528: Remove unused futures dependency from arrow-flight

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #528:
URL: https://github.com/apache/arrow-rs/pull/528#issuecomment-875013624


   # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/528?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#528](https://codecov.io/gh/apache/arrow-rs/pull/528?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d964619) into [master](https://codecov.io/gh/apache/arrow-rs/commit/a1aace846f29dc4346b01289cad246dd99c2e3ed?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a1aace8) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head d964619 differs from pull request most recent head f64f3c1. Consider uploading reports for the commit f64f3c1 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow-rs/pull/528/graphs/tree.svg?width=650&height=150&src=pr&token=pq9V9qWZ1N&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/arrow-rs/pull/528?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #528   +/-   ##
   =======================================
     Coverage   82.54%   82.54%           
   =======================================
     Files         167      167           
     Lines       45956    45956           
   =======================================
     Hits        37933    37933           
     Misses       8023     8023           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/528?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/528?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a1aace8...f64f3c1](https://codecov.io/gh/apache/arrow-rs/pull/528?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org