You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Vera Volynets (JIRA)" <ji...@apache.org> on 2007/01/29 12:59:49 UTC
[jira] Created: (HARMONY-3073) [drlvm][classloader] Eliminate
platform.h file from vm
[drlvm][classloader] Eliminate platform.h file from vm
------------------------------------------------------
Key: HARMONY-3073
URL: https://issues.apache.org/jira/browse/HARMONY-3073
Project: Harmony
Issue Type: Improvement
Reporter: Vera Volynets
I suggest to eliminate platform.h file from vm because I want to use icu module which includes its own platform.h file.
This way I avoid conflict.
During platform.h elimination I've noticed that many code lines are dead, so I've deleted them.
Changes in patch:
1) Replace necessary lines from platform.h to platform_lowlevel.h, cleaned unused typedefs and defines.
2) Removed platform.h.
3) Removed java_lang_thead_nt.h as a dead code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3073) [drlvm][classloader] Eliminate
platform.h file from vm
Posted by "Pavel Pervov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468589 ]
Pavel Pervov commented on HARMONY-3073:
---------------------------------------
It is always good to throw away couple hundred lines of dead code. :) Nice work. Ready for commit.
> [drlvm][classloader] Eliminate platform.h file from vm
> ------------------------------------------------------
>
> Key: HARMONY-3073
> URL: https://issues.apache.org/jira/browse/HARMONY-3073
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Vera Volynets
> Attachments: platform_header_elimination_20070129.patch
>
>
> I suggest to eliminate platform.h file from vm because I want to use icu module which includes its own platform.h file.
> This way I avoid conflict.
> During platform.h elimination I've noticed that many code lines are dead, so I've deleted them.
> Changes in patch:
> 1) Replace necessary lines from platform.h to platform_lowlevel.h, cleaned unused typedefs and defines.
> 2) Removed platform.h.
> 3) Removed java_lang_thead_nt.h as a dead code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-3073) [drlvm][classloader] Eliminate
platform.h file from vm
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky resolved HARMONY-3073.
----------------------------------------
Resolution: Fixed
Patch applied at 501408. Please check that it was applied as expected.
> [drlvm][classloader] Eliminate platform.h file from vm
> ------------------------------------------------------
>
> Key: HARMONY-3073
> URL: https://issues.apache.org/jira/browse/HARMONY-3073
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Vera Volynets
> Assigned To: Gregory Shimansky
> Attachments: platform_header_elimination_20070129.patch
>
>
> I suggest to eliminate platform.h file from vm because I want to use icu module which includes its own platform.h file.
> This way I avoid conflict.
> During platform.h elimination I've noticed that many code lines are dead, so I've deleted them.
> Changes in patch:
> 1) Replace necessary lines from platform.h to platform_lowlevel.h, cleaned unused typedefs and defines.
> 2) Removed platform.h.
> 3) Removed java_lang_thead_nt.h as a dead code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-3073) [drlvm][classloader] Eliminate
platform.h file from vm
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky closed HARMONY-3073.
--------------------------------------
No response, assuming ok.
> [drlvm][classloader] Eliminate platform.h file from vm
> ------------------------------------------------------
>
> Key: HARMONY-3073
> URL: https://issues.apache.org/jira/browse/HARMONY-3073
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Vera Volynets
> Assignee: Gregory Shimansky
> Attachments: platform_header_elimination_20070129.patch
>
>
> I suggest to eliminate platform.h file from vm because I want to use icu module which includes its own platform.h file.
> This way I avoid conflict.
> During platform.h elimination I've noticed that many code lines are dead, so I've deleted them.
> Changes in patch:
> 1) Replace necessary lines from platform.h to platform_lowlevel.h, cleaned unused typedefs and defines.
> 2) Removed platform.h.
> 3) Removed java_lang_thead_nt.h as a dead code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3073) [drlvm][classloader] Eliminate
platform.h file from vm
Posted by "Vera Volynets (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vera Volynets updated HARMONY-3073:
-----------------------------------
Attachment: platform_header_elimination_20070129.patch
> [drlvm][classloader] Eliminate platform.h file from vm
> ------------------------------------------------------
>
> Key: HARMONY-3073
> URL: https://issues.apache.org/jira/browse/HARMONY-3073
> Project: Harmony
> Issue Type: Improvement
> Reporter: Vera Volynets
> Attachments: platform_header_elimination_20070129.patch
>
>
> I suggest to eliminate platform.h file from vm because I want to use icu module which includes its own platform.h file.
> This way I avoid conflict.
> During platform.h elimination I've noticed that many code lines are dead, so I've deleted them.
> Changes in patch:
> 1) Replace necessary lines from platform.h to platform_lowlevel.h, cleaned unused typedefs and defines.
> 2) Removed platform.h.
> 3) Removed java_lang_thead_nt.h as a dead code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-3073) [drlvm][classloader] Eliminate
platform.h file from vm
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky reassigned HARMONY-3073:
------------------------------------------
Assignee: Gregory Shimansky
> [drlvm][classloader] Eliminate platform.h file from vm
> ------------------------------------------------------
>
> Key: HARMONY-3073
> URL: https://issues.apache.org/jira/browse/HARMONY-3073
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Vera Volynets
> Assigned To: Gregory Shimansky
> Attachments: platform_header_elimination_20070129.patch
>
>
> I suggest to eliminate platform.h file from vm because I want to use icu module which includes its own platform.h file.
> This way I avoid conflict.
> During platform.h elimination I've noticed that many code lines are dead, so I've deleted them.
> Changes in patch:
> 1) Replace necessary lines from platform.h to platform_lowlevel.h, cleaned unused typedefs and defines.
> 2) Removed platform.h.
> 3) Removed java_lang_thead_nt.h as a dead code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3073) [drlvm][classloader] Eliminate
platform.h file from vm
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky updated HARMONY-3073:
---------------------------------------
Component/s: DRLVM
> [drlvm][classloader] Eliminate platform.h file from vm
> ------------------------------------------------------
>
> Key: HARMONY-3073
> URL: https://issues.apache.org/jira/browse/HARMONY-3073
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Vera Volynets
> Attachments: platform_header_elimination_20070129.patch
>
>
> I suggest to eliminate platform.h file from vm because I want to use icu module which includes its own platform.h file.
> This way I avoid conflict.
> During platform.h elimination I've noticed that many code lines are dead, so I've deleted them.
> Changes in patch:
> 1) Replace necessary lines from platform.h to platform_lowlevel.h, cleaned unused typedefs and defines.
> 2) Removed platform.h.
> 3) Removed java_lang_thead_nt.h as a dead code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.