You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/07/22 06:35:18 UTC

[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #6563: Changed log4j settings

rohityadavcloud commented on code in PR #6563:
URL: https://github.com/apache/cloudstack/pull/6563#discussion_r927334289


##########
agent/conf/log4j-cloud.xml.in:
##########
@@ -29,10 +29,15 @@ under the License.
    <appender name="FILE" class="org.apache.log4j.rolling.RollingFileAppender">
       <param name="Append" value="true"/>
       <param name="Threshold" value="INFO"/>
-      <rollingPolicy class="org.apache.log4j.rolling.TimeBasedRollingPolicy">
-        <param name="FileNamePattern" value="@AGENTLOG@.%d{yyyy-MM-dd}.gz"/>
+      <rollingPolicy class="org.apache.log4j.rolling.FixedWindowRollingPolicy">
+        <param name="FileNamePattern" value="@AGENTLOG@.%i.gz"/>

Review Comment:
   This may cause some admins stress, given many may be used to date/time stamp based logs. If the fix is limited to the log4j xml configs, you can simply configure this for your environments (not necessarily upstream codebase).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org