[GitHub] [spark] ulysses-you commented on a change in pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config

[GitBox <gi...@apache.org>]

ulysses-you commented on a change in pull request #31732:
URL: https://github.com/apache/spark/pull/31732#discussion_r587210944



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala
##########
@@ -909,4 +910,17 @@ abstract class SQLViewSuite extends QueryTest with SQLTestUtils {
       }
     }
   }
+
+  test("SPARK-34613: Fix view does not capture disable hint config") {

Review comment:
       Yes it will fail. View just use the stored config to do anlysis. Before this fix, the config of disable hint can't be captured, then we would always use the default value `false`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org