[GitHub] [superset] dvchristianbors commented on pull request #19572: fix(chartdata): disable sqlparse calls for chart data requests to improve querying performance

[GitBox <gi...@apache.org>]

dvchristianbors commented on PR #19572:
URL: https://github.com/apache/superset/pull/19572#issuecomment-1091813640

   > Thanks for the contribution @dvchristianbors . While I agree this performance hit is very problematic, we currently rely heavily on `sqlparse` for some very critical validation logic. Therefore, some of the changes in this PR will not be possible in their current form.
   > 
   > I looked into the original issue that you linked here, and noticed there seems to be open PRs on `sqlparse` that may address some of the observed performance issues. From our perspective, the optimal solution would be to fix the performance issues in the underlying library first, and only then optimize in Superset where needed. Out of curiosity, have you tested running Superset with a fork of `sqlparse` that has applied some of those open PRs? It would be interesting to see if they have a significant impact on performance..
   
   Thanks for your comments. I agree that this would be the best option. I forked sqlparse and merged the PRs which supposedly addressed the issues, however I cannot confirm that they did improve performance (at least for the tested use cases). 
   
   I will further investigate the issue in sqlparse itself, and propose new changes as soon as I found a better solution.
   @villebro Should I post my updates and revised solution here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org