You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org> on 2016/06/09 21:10:12 UTC
[Impala-CR](cdh5-trunk) Add kill cluster marker to KMS
Taras Bobrovytsky has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3354
Change subject: Add kill cluster marker to KMS
......................................................................
Add kill cluster marker to KMS
If PID files of each process in the mini cluster get deleted for some
reason, it should still possible to kill them because each process is
marked with "-DIBelongToTheMiniCluster". It turns out that the KMS
process was not being marked. This patch fixes this.
Change-Id: I0398dec94be3ae91548d11a79c1d5eec0ad3dadb
---
M testdata/cluster/node_templates/common/etc/init.d/common.tmpl
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/54/3354/1
--
To view, visit http://gerrit.cloudera.org:8080/3354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0398dec94be3ae91548d11a79c1d5eec0ad3dadb
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
[Impala-CR](cdh5-trunk) Add kill cluster marker to KMS
Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Taras Bobrovytsky has posted comments on this change.
Change subject: Add kill cluster marker to KMS
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3354/1/testdata/cluster/node_templates/common/etc/init.d/common.tmpl
File testdata/cluster/node_templates/common/etc/init.d/common.tmpl:
Line 12: export CATALINA_OPTS+=" -D${KILL_CLUSTER_MARKER}"
> Maybe add a note saying this is for KMS?
Done
--
To view, visit http://gerrit.cloudera.org:8080/3354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0398dec94be3ae91548d11a79c1d5eec0ad3dadb
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Casey Ching <ca...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-CR](cdh5-trunk) Add kill cluster marker to KMS
Posted by "Casey Ching (Code Review)" <ge...@cloudera.org>.
Casey Ching has posted comments on this change.
Change subject: Add kill cluster marker to KMS
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3354/1/testdata/cluster/node_templates/common/etc/init.d/common.tmpl
File testdata/cluster/node_templates/common/etc/init.d/common.tmpl:
Line 12: export CATALINA_OPTS+=" -D${KILL_CLUSTER_MARKER}"
Maybe add a note saying this is for KMS?
--
To view, visit http://gerrit.cloudera.org:8080/3354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0398dec94be3ae91548d11a79c1d5eec0ad3dadb
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Casey Ching <ca...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-CR](cdh5-trunk) Add kill cluster marker to KMS
Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Taras Bobrovytsky has posted comments on this change.
Change subject: Add kill cluster marker to KMS
......................................................................
Patch Set 2: Code-Review+2
Carrying the +2.
--
To view, visit http://gerrit.cloudera.org:8080/3354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0398dec94be3ae91548d11a79c1d5eec0ad3dadb
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Casey Ching <ca...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) Add kill cluster marker to KMS
Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Hello Casey Ching,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3354
to look at the new patch set (#2).
Change subject: Add kill cluster marker to KMS
......................................................................
Add kill cluster marker to KMS
If PID files of each process in the mini cluster get deleted for some
reason, it should still possible to kill them because each process is
marked with "-DIBelongToTheMiniCluster". It turns out that the KMS
process was not being marked. This patch fixes this.
Change-Id: I0398dec94be3ae91548d11a79c1d5eec0ad3dadb
---
M testdata/cluster/node_templates/common/etc/init.d/common.tmpl
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/54/3354/2
--
To view, visit http://gerrit.cloudera.org:8080/3354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0398dec94be3ae91548d11a79c1d5eec0ad3dadb
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Casey Ching <ca...@cloudera.com>
[Impala-CR](cdh5-trunk) Add kill cluster marker to KMS
Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Taras Bobrovytsky has posted comments on this change.
Change subject: Add kill cluster marker to KMS
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/3354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0398dec94be3ae91548d11a79c1d5eec0ad3dadb
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Casey Ching <ca...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) Add kill cluster marker to KMS
Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Taras Bobrovytsky has submitted this change and it was merged.
Change subject: Add kill cluster marker to KMS
......................................................................
Add kill cluster marker to KMS
If PID files of each process in the mini cluster get deleted for some
reason, it should still possible to kill them because each process is
marked with "-DIBelongToTheMiniCluster". It turns out that the KMS
process was not being marked. This patch fixes this.
Change-Id: I0398dec94be3ae91548d11a79c1d5eec0ad3dadb
Reviewed-on: http://gerrit.cloudera.org:8080/3354
Reviewed-by: Taras Bobrovytsky <tb...@cloudera.com>
Tested-by: Taras Bobrovytsky <tb...@cloudera.com>
---
M testdata/cluster/node_templates/common/etc/init.d/common.tmpl
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Taras Bobrovytsky: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/3354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0398dec94be3ae91548d11a79c1d5eec0ad3dadb
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Casey Ching <ca...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
[Impala-CR](cdh5-trunk) Add kill cluster marker to KMS
Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Taras Bobrovytsky has posted comments on this change.
Change subject: Add kill cluster marker to KMS
......................................................................
Patch Set 2:
Verified in http://sandbox.jenkins.cloudera.com/view/Impala/view/Private-Utility/job/impala-private-build-and-test/3382/
--
To view, visit http://gerrit.cloudera.org:8080/3354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0398dec94be3ae91548d11a79c1d5eec0ad3dadb
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Casey Ching <ca...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: No