You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/19 18:16:56 UTC
[GitHub] [arrow] Dandandan opened a new pull request #9269: ARROW-11321: [Rust][DataFusion] Fix DataFusion compilation error
Dandandan opened a new pull request #9269:
URL: https://github.com/apache/arrow/pull/9269
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Dandandan commented on pull request #9269: ARROW-11321: [Rust][DataFusion] Fix DataFusion compilation error
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #9269:
URL: https://github.com/apache/arrow/pull/9269#issuecomment-763055227
I am really excited for the changes w.r.t. performance in the merged PRs!
This will allow us to further improve some kernels :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9269: ARROW-11321: [Rust][DataFusion] Fix DataFusion compilation error
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9269:
URL: https://github.com/apache/arrow/pull/9269#issuecomment-763048459
🚀
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #9269: ARROW-11321: [Rust][DataFusion] Fix DataFusion compilation error
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #9269:
URL: https://github.com/apache/arrow/pull/9269#issuecomment-763044552
cc @alamb
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9269: ARROW-11321: [Rust][DataFusion] Fix DataFusion compilation error
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9269:
URL: https://github.com/apache/arrow/pull/9269#issuecomment-763045563
I ran this locally and it fixes the build for me. I plan to merge this in prior to CI finishing to get master back to green
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9269: ARROW-11321: [Rust][DataFusion] Fix DataFusion compilation error
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9269:
URL: https://github.com/apache/arrow/pull/9269#issuecomment-763054800
No worries @jorgecarleitao -- I think this was likely to happen given the backup of PRs waiting to go on to master :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Dandandan commented on pull request #9269: ARROW-11321: [Rust][DataFusion] Fix DataFusion compilation error
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #9269:
URL: https://github.com/apache/arrow/pull/9269#issuecomment-763037837
Yeah those submodules seems to cause some issues lately :/. Should be fixed now @jorgecarleitao
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9269: ARROW-11321: [Rust][DataFusion] Fix DataFusion compilation error
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9269:
URL: https://github.com/apache/arrow/pull/9269#issuecomment-763042350
https://issues.apache.org/jira/browse/ARROW-11321
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9269: ARROW-11321: [Rust][DataFusion] Fix DataFusion compilation error
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9269:
URL: https://github.com/apache/arrow/pull/9269#issuecomment-763047240
For anyone else following along, the error this PR fixes looks like the following (from https://github.com/apache/arrow/runs/1729540155):
```
Compiling arrow-flight v3.0.0-SNAPSHOT (/__w/arrow/arrow/rust/arrow-flight)
Compiling tonic v0.3.1
Compiling datafusion v3.0.0-SNAPSHOT (/__w/arrow/arrow/rust/datafusion)
error[E0061]: this function takes 2 arguments but 1 argument was supplied
--> datafusion/src/physical_plan/parquet.rs:712:25
|
712 | data_buffer.resize(data_buffer.len() + data_size);
| ^^^^^^ ----------------------------- supplied 1 argument
| |
| expected 2 arguments
error: aborting due to previous error
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #9269: ARROW-11321: [Rust][DataFusion] Fix DataFusion compilation error
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #9269:
URL: https://github.com/apache/arrow/pull/9269#issuecomment-763051329
Thanks a lot, @Dandandan and @alamb , and sorry for the mess 😞
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #9269: ARROW-11321: [Rust][DataFusion] Fix DataFusion compilation error
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #9269:
URL: https://github.com/apache/arrow/pull/9269#issuecomment-763032219
This has an unrelated change on a submodule?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #9269: ARROW-11321: [Rust][DataFusion] Fix DataFusion compilation error
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9269:
URL: https://github.com/apache/arrow/pull/9269
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org