You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by doanduyhai <gi...@git.apache.org> on 2016/04/28 21:38:12 UTC
[GitHub] incubator-zeppelin pull request: [Zeppelin-742] Add documentation ...
GitHub user doanduyhai opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/865
[Zeppelin-742] Add documentation for front-end AngularJS AP
### What is this PR for?
This JIRA:
* add documentation for the new paragraphId display in the paragraph command dialog. Instead of just adding some description to the paragraphId, I took the opportunity to also document the entire Zeppelin UI Layout and added a menu entry **UI Layout** under menu **QuickStart**. It is inspired by the content of the talk on Zeppelin at different conferences
* rename the menu **Display System** / **Angular** to **Display System** / **Back-end Angular Interactions**
* add a new entry **Front-end Angular Interactions** under the menu **Display System** to describe the new front-end AngularJS API introduced by this epic
_This is a sub-task of epic **[ZEPPELIN-635]**_
### What type of PR is it?
[Documentation]
### Todos
* [ ] - Check documentation
### What is the Jira issue?
**[ZEPPELIN-6742]**
### How should this be tested?
Build Zeppelin documentation locally and check
### Screenshots (if appropriate)
New **QuickStart** / **UI Layout** documentation which mentions the **paragraphId**

New **Display System** / **Front-end Angular Interactions** menu to describe the new front-end AngularJS API introduced by this epic

### Questions:
* Does the licenses files need update? --> No
* Is there breaking changes for older versions? --> No
* Does this needs documentation? --> No
[ZEPPELIN-635]: https://issues.apache.org/jira/browse/ZEPPELIN-635
[ZEPPELIN-742]: https://issues.apache.org/jira/browse/ZEPPELIN-742
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/doanduyhai/incubator-zeppelin ZEPPELIN-742
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/865.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #865
----
commit 0b719d37817e61ef8156e380e4af2556e562d7bd
Author: DuyHai DOAN <do...@gmail.com>
Date: 2016-04-28T09:19:20Z
[ZEPPELIN-742] Add documentation for Zeppelin UI Layout & paragraphId
commit babf2e0b081777be7a76a4bc3d347c359dd607dd
Author: DuyHai DOAN <do...@gmail.com>
Date: 2016-04-28T17:50:09Z
[ZEPPELIN-742] Add documentation for front-end AngularJS API
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-742] Add documentation ...
Posted by doanduyhai <gi...@git.apache.org>.
Github user doanduyhai commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/865#issuecomment-215666487
Build green :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-742] Add documentation ...
Posted by doanduyhai <gi...@git.apache.org>.
Github user doanduyhai commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/865#issuecomment-216628118
Ping @Leemoonsoo @felixcheung
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-742] Add documentation ...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/865#issuecomment-215609009
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-742] Add documentation ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/865#issuecomment-216637952
LGTM and merge if there're no more discussions!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-742] Add documentation ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/865
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin-742] Add documentation ...
Posted by doanduyhai <gi...@git.apache.org>.
Github user doanduyhai commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/865#issuecomment-215539051
Ping @Leemoonsoo & @felixcheung
Finally the **LAST** JIRA for this **EPIC** !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-742] Add documentation ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/865#issuecomment-215901294
Great work @doanduyhai.
One thing is, instead of 'Back-end Angular Interactions' and 'Front-end Angular Interactions', how about 'Angular (backend API)', 'Angular (frontend API)' ? Because, they're both api for front-end <-> back-end interactions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-742] Add documentation ...
Posted by doanduyhai <gi...@git.apache.org>.
Github user doanduyhai commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/865#issuecomment-216018509
@Leemoonsoo Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---