You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Zheng Shao (JIRA)" <ji...@apache.org> on 2010/01/27 10:07:34 UTC
[jira] Created: (HIVE-1108) QueryPlan to be independent from
BaseSemanticAnalyzer
QueryPlan to be independent from BaseSemanticAnalyzer
-----------------------------------------------------
Key: HIVE-1108
URL: https://issues.apache.org/jira/browse/HIVE-1108
Project: Hadoop Hive
Issue Type: Improvement
Components: Query Processor
Affects Versions: 0.6.0
Reporter: Zheng Shao
Assignee: Zheng Shao
QueryPlan is the class to store compiled plan. However currently it contains references to BaseSemanticAnalyzer.
We should remove the reference. Otherwise QueryPlan won't be serializable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1108) QueryPlan to be independent from
BaseSemanticAnalyzer
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805608#action_12805608 ]
Namit Jain commented on HIVE-1108:
----------------------------------
65 private ArrayList<Task<? extends Serializable>> rootTasks;
66 private FetchTask fetchTask;
67 private HashSet<ReadEntity> inputs;
68 private HashSet<WriteEntity> outputs;
69
70 private HashMap<String, String> idToTableNameMap;
Do you think instead of adding the following fields in QueryPlan, you might create a new serializable structure and share it between SemanticAnalyzer and QueryPlan ?
> QueryPlan to be independent from BaseSemanticAnalyzer
> -----------------------------------------------------
>
> Key: HIVE-1108
> URL: https://issues.apache.org/jira/browse/HIVE-1108
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.6.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Attachments: HIVE-1108.1.patch
>
>
> QueryPlan is the class to store compiled plan. However currently it contains references to BaseSemanticAnalyzer.
> We should remove the reference. Otherwise QueryPlan won't be serializable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1108) QueryPlan to be independent from
BaseSemanticAnalyzer
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805639#action_12805639 ]
Carl Steinbach commented on HIVE-1108:
--------------------------------------
bq. Do you think instead of adding the following fields in QueryPlan, you might create a new serializable structure and share it between SemanticAnalyzer and QueryPlan?
That's the role of the PhysicalPlan class described in HIVE-924. If Zheng wants to push this patch in now I can address Namit's concerns in a day or so with the LogicaPlan/PhysicalPlan patch.
> QueryPlan to be independent from BaseSemanticAnalyzer
> -----------------------------------------------------
>
> Key: HIVE-1108
> URL: https://issues.apache.org/jira/browse/HIVE-1108
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.6.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Attachments: HIVE-1108.1.patch
>
>
> QueryPlan is the class to store compiled plan. However currently it contains references to BaseSemanticAnalyzer.
> We should remove the reference. Otherwise QueryPlan won't be serializable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1108) QueryPlan to be independent from
BaseSemanticAnalyzer
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HIVE-1108:
-----------------------------
Attachment: (was: HIVE-1108.1.patch)
> QueryPlan to be independent from BaseSemanticAnalyzer
> -----------------------------------------------------
>
> Key: HIVE-1108
> URL: https://issues.apache.org/jira/browse/HIVE-1108
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.6.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
>
> QueryPlan is the class to store compiled plan. However currently it contains references to BaseSemanticAnalyzer.
> We should remove the reference. Otherwise QueryPlan won't be serializable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HIVE-1108) QueryPlan to be independent from
BaseSemanticAnalyzer
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain resolved HIVE-1108.
------------------------------
Resolution: Fixed
Fix Version/s: 0.6.0
Hadoop Flags: [Reviewed]
Committed. Thanks Zheng
> QueryPlan to be independent from BaseSemanticAnalyzer
> -----------------------------------------------------
>
> Key: HIVE-1108
> URL: https://issues.apache.org/jira/browse/HIVE-1108
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.6.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Fix For: 0.6.0
>
> Attachments: HIVE-1108.1.patch
>
>
> QueryPlan is the class to store compiled plan. However currently it contains references to BaseSemanticAnalyzer.
> We should remove the reference. Otherwise QueryPlan won't be serializable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1108) QueryPlan to be independent from
BaseSemanticAnalyzer
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HIVE-1108:
-----------------------------
Attachment: HIVE-1108.1.patch
> QueryPlan to be independent from BaseSemanticAnalyzer
> -----------------------------------------------------
>
> Key: HIVE-1108
> URL: https://issues.apache.org/jira/browse/HIVE-1108
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.6.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Attachments: HIVE-1108.1.patch
>
>
> QueryPlan is the class to store compiled plan. However currently it contains references to BaseSemanticAnalyzer.
> We should remove the reference. Otherwise QueryPlan won't be serializable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1108) QueryPlan to be independent from
BaseSemanticAnalyzer
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805667#action_12805667 ]
Namit Jain commented on HIVE-1108:
----------------------------------
OK, I will commit it if the tests pass
+1
> QueryPlan to be independent from BaseSemanticAnalyzer
> -----------------------------------------------------
>
> Key: HIVE-1108
> URL: https://issues.apache.org/jira/browse/HIVE-1108
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.6.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Attachments: HIVE-1108.1.patch
>
>
> QueryPlan is the class to store compiled plan. However currently it contains references to BaseSemanticAnalyzer.
> We should remove the reference. Otherwise QueryPlan won't be serializable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1108) QueryPlan to be independent from
BaseSemanticAnalyzer
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805658#action_12805658 ]
Zheng Shao commented on HIVE-1108:
----------------------------------
Thanks for taking care of that Carl! Talked with Namit offline. He will commit this.
> QueryPlan to be independent from BaseSemanticAnalyzer
> -----------------------------------------------------
>
> Key: HIVE-1108
> URL: https://issues.apache.org/jira/browse/HIVE-1108
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.6.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Attachments: HIVE-1108.1.patch
>
>
> QueryPlan is the class to store compiled plan. However currently it contains references to BaseSemanticAnalyzer.
> We should remove the reference. Otherwise QueryPlan won't be serializable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1108) QueryPlan to be independent from
BaseSemanticAnalyzer
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HIVE-1108:
-----------------------------
Attachment: HIVE-1108.1.patch
> QueryPlan to be independent from BaseSemanticAnalyzer
> -----------------------------------------------------
>
> Key: HIVE-1108
> URL: https://issues.apache.org/jira/browse/HIVE-1108
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.6.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Attachments: HIVE-1108.1.patch
>
>
> QueryPlan is the class to store compiled plan. However currently it contains references to BaseSemanticAnalyzer.
> We should remove the reference. Otherwise QueryPlan won't be serializable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.