You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Mryange (via GitHub)" <gi...@apache.org> on 2026/03/24 09:57:10 UTC
[PR] [refine](code) Add comments and benchmarks for ColumnView. [doris]
Mryange opened a new pull request, #61678:
URL: https://github.com/apache/doris/pull/61678
### What problem does this PR solve?
1. Expensive per-element operations (e.g. geo functions, complex string ops):
Use ColumnView freely — its overhead is negligible relative to the work.
2. Cheap per-element operations that the compiler can inline (e.g. simple arithmetic):
a) Inputs are NOT nullable (e.g. the function framework already strips nullable):
Safe to use. The compiler optimizes the is_const branch into code equivalent
to hand-written direct array access (verified via assembly and benchmarks).
b) Inputs involve nullable columns:
- Unary operations: safe to use, the compiler still optimizes effectively.
- Binary / ternary operations: the combined is_null_at checks across multiple
columns inhibit compiler vectorization and branch optimization, causing
significant regression (~1.4x for binary, ~1.8x for ternary in benchmarks).
In this case, hand-written column access is recommended for best performance.
In summary, ColumnView is designed to eliminate the combinatorial explosion of
handling 4 column forms. It is suitable for the vast majority of use cases.
Only the specific combination of "cheap computation + nullable + multi-column"
requires weighing whether to hand-write the access code.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](code) Add comments and benchmarks for ColumnView. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61678:
URL: https://github.com/apache/doris/pull/61678#issuecomment-4117219383
<details>
<summary>TPC-DS: <b>Total hot run time: 168948 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2419829ded75b99e9e40c4c9a928dcd0b7266a78, data reload: false
query5 4332 633 501 501
query6 334 240 206 206
query7 4205 462 270 270
query8 352 242 225 225
query9 8704 2711 2688 2688
query10 508 407 333 333
query11 6994 5080 4869 4869
query12 175 125 125 125
query13 1288 450 348 348
query14 5775 3725 3492 3492
query14_1 2874 2852 2781 2781
query15 197 188 176 176
query16 975 491 440 440
query17 859 702 610 610
query18 2443 446 345 345
query19 211 201 186 186
query20 133 128 125 125
query21 216 135 107 107
query22 13345 13888 15044 13888
query23 16756 16193 16000 16000
query23_1 16078 16235 15612 15612
query24 7197 1621 1208 1208
query24_1 1219 1222 1232 1222
query25 539 463 418 418
query26 1246 259 152 152
query27 2788 511 295 295
query28 4469 1820 1824 1820
query29 867 584 492 492
query30 297 227 191 191
query31 983 949 888 888
query32 85 73 72 72
query33 520 337 283 283
query34 889 884 532 532
query35 641 666 584 584
query36 1039 1119 991 991
query37 130 95 85 85
query38 2908 2903 2890 2890
query39 874 856 819 819
query39_1 800 796 794 794
query40 229 151 139 139
query41 62 59 60 59
query42 258 256 256 256
query43 242 261 218 218
query44
query45 195 189 178 178
query46 904 974 616 616
query47 2121 2133 2050 2050
query48 311 329 231 231
query49 629 462 382 382
query50 705 290 212 212
query51 4068 4043 4059 4043
query52 265 272 263 263
query53 297 333 291 291
query54 311 278 280 278
query55 91 84 86 84
query56 309 330 314 314
query57 1898 1805 1667 1667
query58 284 272 273 272
query59 2807 2950 2736 2736
query60 336 343 335 335
query61 153 151 153 151
query62 627 588 543 543
query63 309 277 284 277
query64 5127 1355 1096 1096
query65
query66 1491 471 406 406
query67 24192 24451 24162 24162
query68
query69 405 315 299 299
query70 978 1002 951 951
query71 337 307 299 299
query72 2831 2746 2428 2428
query73 542 549 318 318
query74 9645 9590 9402 9402
query75 2859 2773 2469 2469
query76 2293 1049 689 689
query77 364 403 321 321
query78 10934 11081 10440 10440
query79 1137 777 575 575
query80 1349 648 557 557
query81 537 255 228 228
query82 1059 155 122 122
query83 342 272 252 252
query84 302 123 109 109
query85 1003 575 526 526
query86 416 312 297 297
query87 3129 3126 3012 3012
query88 3622 2719 2702 2702
query89 431 375 351 351
query90 2003 186 184 184
query91 200 183 158 158
query92 80 82 74 74
query93 915 852 493 493
query94 653 328 318 318
query95 609 364 407 364
query96 655 515 232 232
query97 2464 2491 2407 2407
query98 239 220 227 220
query99 1014 997 965 965
Total cold run time: 250272 ms
Total hot run time: 168948 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](code) Add comments and benchmarks for ColumnView. [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #61678:
URL: https://github.com/apache/doris/pull/61678#issuecomment-4124067870
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](code) Add comments and benchmarks for ColumnView. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61678:
URL: https://github.com/apache/doris/pull/61678#issuecomment-4124646370
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/61678_2419829ded75b99e9e40c4c9a928dcd0b7266a78_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/61678_2419829ded75b99e9e40c4c9a928dcd0b7266a78_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.26% (26249/36835) |
| Line Coverage | 54.12% (275768/509524) |
| Region Coverage | 51.14% (227879/445619) |
| Branch Coverage | 52.72% (98554/186934) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](code) Add comments and benchmarks for ColumnView. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61678:
URL: https://github.com/apache/doris/pull/61678#issuecomment-4117143474
<details>
<summary>TPC-H: <b>Total hot run time: 26598 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2419829ded75b99e9e40c4c9a928dcd0b7266a78, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17578 4513 4303 4303
q2 q3 10648 789 524 524
q4 4676 349 251 251
q5 7569 1224 1028 1028
q6 174 176 145 145
q7 770 834 699 699
q8 9313 1464 1336 1336
q9 4903 4788 4696 4696
q10 6327 1926 1672 1672
q11 458 258 244 244
q12 757 581 473 473
q13 18046 2691 1931 1931
q14 222 237 217 217
q15 q16 748 739 662 662
q17 759 840 451 451
q18 5931 5376 5211 5211
q19 1137 979 619 619
q20 545 479 381 381
q21 4565 1851 1434 1434
q22 348 321 432 321
Total cold run time: 95474 ms
Total hot run time: 26598 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4676 4615 4672 4615
q2 q3 3924 4373 3853 3853
q4 888 1208 817 817
q5 4092 4352 4388 4352
q6 190 178 139 139
q7 1766 1637 1538 1538
q8 2497 2770 2653 2653
q9 7676 7382 7392 7382
q10 3736 3977 3782 3782
q11 512 443 464 443
q12 497 601 458 458
q13 2489 3046 2094 2094
q14 300 306 286 286
q15 q16 729 801 770 770
q17 1186 1593 1382 1382
q18 7350 6923 6732 6732
q19 935 1009 935 935
q20 2281 2171 2010 2010
q21 3974 3496 3415 3415
q22 453 428 384 384
Total cold run time: 50151 ms
Total hot run time: 48040 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](code) Add comments and benchmarks for ColumnView. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61678:
URL: https://github.com/apache/doris/pull/61678#issuecomment-4153958125
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/61678_2419829ded75b99e9e40c4c9a928dcd0b7266a78_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/61678_2419829ded75b99e9e40c4c9a928dcd0b7266a78_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.08% (26994/36940) |
| Line Coverage | 56.50% (289371/512155) |
| Region Coverage | 53.58% (240172/448230) |
| Branch Coverage | 55.19% (104020/188479) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](code) Add comments and benchmarks for ColumnView. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61678:
URL: https://github.com/apache/doris/pull/61678#issuecomment-4153406107
<details>
<summary>TPC-DS: <b>Total hot run time: 169117 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2419829ded75b99e9e40c4c9a928dcd0b7266a78, data reload: false
query5 4334 655 513 513
query6 326 228 205 205
query7 4209 470 258 258
query8 342 251 238 238
query9 8729 2715 2689 2689
query10 521 412 377 377
query11 6963 5109 4863 4863
query12 179 125 121 121
query13 1269 431 330 330
query14 5723 3744 3464 3464
query14_1 2853 2888 2783 2783
query15 204 191 174 174
query16 993 469 424 424
query17 858 722 604 604
query18 2429 458 361 361
query19 218 214 183 183
query20 133 128 126 126
query21 224 138 114 114
query22 13226 13991 14420 13991
query23 17018 16356 15994 15994
query23_1 16097 16331 16008 16008
query24 7129 1619 1236 1236
query24_1 1246 1239 1239 1239
query25 579 495 451 451
query26 1245 270 158 158
query27 2763 487 300 300
query28 4514 1865 1873 1865
query29 888 583 504 504
query30 302 226 195 195
query31 1018 971 863 863
query32 87 72 77 72
query33 530 345 294 294
query34 898 887 527 527
query35 630 681 611 611
query36 1090 1108 992 992
query37 140 98 85 85
query38 2926 2898 2920 2898
query39 856 840 820 820
query39_1 798 813 815 813
query40 239 156 142 142
query41 68 65 64 64
query42 261 259 266 259
query43 248 258 240 240
query44
query45 202 192 180 180
query46 879 976 605 605
query47 2143 2176 2052 2052
query48 314 316 228 228
query49 627 451 386 386
query50 693 276 213 213
query51 4096 4017 3954 3954
query52 258 265 255 255
query53 306 336 285 285
query54 295 268 262 262
query55 94 83 82 82
query56 307 307 312 307
query57 1913 1745 1632 1632
query58 286 268 265 265
query59 2784 2978 2738 2738
query60 338 332 319 319
query61 155 151 151 151
query62 631 585 518 518
query63 304 280 275 275
query64 5114 1328 1017 1017
query65
query66 1461 460 348 348
query67 24171 24242 24330 24242
query68
query69 396 304 291 291
query70 983 965 858 858
query71 336 298 295 295
query72 2844 2708 2472 2472
query73 539 553 312 312
query74 9587 9590 9441 9441
query75 2878 2797 2452 2452
query76 2284 1023 669 669
query77 373 389 308 308
query78 10893 11111 10477 10477
query79 2958 758 572 572
query80 1746 636 545 545
query81 545 259 230 230
query82 1004 153 118 118
query83 338 264 246 246
query84 303 124 95 95
query85 942 510 471 471
query86 416 309 287 287
query87 3139 3142 2998 2998
query88 3531 2644 2644 2644
query89 427 374 336 336
query90 1981 179 166 166
query91 170 169 143 143
query92 77 73 67 67
query93 1257 848 513 513
query94 659 285 285 285
query95 583 399 326 326
query96 651 513 227 227
query97 2454 2513 2444 2444
query98 238 219 216 216
query99 1013 1009 944 944
Total cold run time: 252220 ms
Total hot run time: 169117 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](code) Add comments and benchmarks for ColumnView. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61678:
URL: https://github.com/apache/doris/pull/61678#issuecomment-4124430018
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/61678_2419829ded75b99e9e40c4c9a928dcd0b7266a78_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/61678_2419829ded75b99e9e40c4c9a928dcd0b7266a78_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.26% (26249/36835) |
| Line Coverage | 54.12% (275768/509524) |
| Region Coverage | 51.14% (227879/445619) |
| Branch Coverage | 52.72% (98554/186934) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](code) Add comments and benchmarks for ColumnView. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61678:
URL: https://github.com/apache/doris/pull/61678#issuecomment-4154113310
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/2419829ded75b99e9e40c4c9a928dcd0b7266a78_2419829ded75b99e9e40c4c9a928dcd0b7266a78/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/2419829ded75b99e9e40c4c9a928dcd0b7266a78_2419829ded75b99e9e40c4c9a928dcd0b7266a78/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.91% (19962/37729) |
| Line Coverage | 36.46% (187292/513733) |
| Region Coverage | 32.71% (145273/444119) |
| Branch Coverage | 33.87% (63654/187913) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](code) Add comments and benchmarks for ColumnView. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #61678:
URL: https://github.com/apache/doris/pull/61678#issuecomment-4205182209
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](code) Add comments and benchmarks for ColumnView. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #61678:
URL: https://github.com/apache/doris/pull/61678#issuecomment-4205181947
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](code) Add comments and benchmarks for ColumnView. [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange closed pull request #61678: [refine](code) Add comments and benchmarks for ColumnView.
URL: https://github.com/apache/doris/pull/61678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](code) Add comments and benchmarks for ColumnView. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61678:
URL: https://github.com/apache/doris/pull/61678#issuecomment-4124404746
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/2419829ded75b99e9e40c4c9a928dcd0b7266a78_2419829ded75b99e9e40c4c9a928dcd0b7266a78/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/2419829ded75b99e9e40c4c9a928dcd0b7266a78_2419829ded75b99e9e40c4c9a928dcd0b7266a78/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.82% (19872/37619) |
| Line Coverage | 36.33% (185660/511098) |
| Region Coverage | 32.57% (143805/441501) |
| Branch Coverage | 33.79% (62968/186372) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](code) Add comments and benchmarks for ColumnView. [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #61678:
URL: https://github.com/apache/doris/pull/61678#issuecomment-4152798253
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](code) Add comments and benchmarks for ColumnView. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61678:
URL: https://github.com/apache/doris/pull/61678#issuecomment-4124180948
<details>
<summary>TPC-DS: <b>Total hot run time: 169242 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2419829ded75b99e9e40c4c9a928dcd0b7266a78, data reload: false
query5 4349 650 508 508
query6 339 230 213 213
query7 4215 463 260 260
query8 359 234 224 224
query9 8746 2736 2683 2683
query10 534 388 338 338
query11 7016 5162 4939 4939
query12 182 131 125 125
query13 1279 466 355 355
query14 5719 3747 3466 3466
query14_1 2889 2876 2841 2841
query15 205 193 179 179
query16 1023 473 372 372
query17 1119 740 637 637
query18 2547 460 362 362
query19 215 224 188 188
query20 134 129 126 126
query21 212 133 115 115
query22 13327 14078 14769 14078
query23 16842 16394 16030 16030
query23_1 15886 15680 15770 15680
query24 7123 1664 1220 1220
query24_1 1192 1228 1250 1228
query25 566 465 402 402
query26 1244 263 150 150
query27 2761 478 291 291
query28 4459 1850 1833 1833
query29 857 572 483 483
query30 302 232 191 191
query31 1018 945 882 882
query32 83 69 74 69
query33 527 331 291 291
query34 889 860 528 528
query35 650 679 618 618
query36 1073 1102 961 961
query37 141 100 92 92
query38 3017 2911 2898 2898
query39 871 821 817 817
query39_1 791 807 792 792
query40 239 155 136 136
query41 65 60 59 59
query42 266 253 256 253
query43 237 247 230 230
query44
query45 194 195 183 183
query46 871 982 611 611
query47 2113 2854 2042 2042
query48 300 319 230 230
query49 633 465 395 395
query50 676 279 210 210
query51 4093 4066 4099 4066
query52 261 272 251 251
query53 299 347 291 291
query54 314 276 302 276
query55 92 88 92 88
query56 323 334 324 324
query57 1958 1658 1706 1658
query58 287 278 274 274
query59 2825 2972 2746 2746
query60 346 343 326 326
query61 163 161 162 161
query62 626 593 532 532
query63 317 283 281 281
query64 5059 1280 1043 1043
query65
query66 1457 454 385 385
query67 24249 24306 24270 24270
query68
query69 403 319 285 285
query70 936 978 953 953
query71 354 316 300 300
query72 2886 2706 2501 2501
query73 528 549 316 316
query74 9676 9575 9402 9402
query75 2895 2757 2476 2476
query76 2296 1038 693 693
query77 372 392 314 314
query78 10943 11122 10519 10519
query79 1123 773 574 574
query80 735 643 550 550
query81 482 258 227 227
query82 1350 155 124 124
query83 380 271 254 254
query84 261 119 99 99
query85 852 497 449 449
query86 357 306 298 298
query87 3168 3152 3014 3014
query88 3548 2658 2651 2651
query89 429 374 347 347
query90 1990 180 179 179
query91 171 162 138 138
query92 77 75 75 75
query93 899 876 489 489
query94 452 333 291 291
query95 599 346 328 328
query96 651 517 233 233
query97 2466 2460 2391 2391
query98 241 220 219 219
query99 1004 987 910 910
Total cold run time: 249903 ms
Total hot run time: 169242 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](code) Add comments and benchmarks for ColumnView. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61678:
URL: https://github.com/apache/doris/pull/61678#issuecomment-4153959706
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/61678_2419829ded75b99e9e40c4c9a928dcd0b7266a78_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/61678_2419829ded75b99e9e40c4c9a928dcd0b7266a78_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.08% (26994/36940) |
| Line Coverage | 56.50% (289371/512155) |
| Region Coverage | 53.58% (240172/448230) |
| Branch Coverage | 55.19% (104020/188479) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](code) Add comments and benchmarks for ColumnView. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61678:
URL: https://github.com/apache/doris/pull/61678#issuecomment-4153987577
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/61678_2419829ded75b99e9e40c4c9a928dcd0b7266a78_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/61678_2419829ded75b99e9e40c4c9a928dcd0b7266a78_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.12% (27011/36940) |
| Line Coverage | 56.54% (289556/512155) |
| Region Coverage | 53.62% (240361/448230) |
| Branch Coverage | 55.23% (104096/188479) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](code) Add comments and benchmarks for ColumnView. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61678:
URL: https://github.com/apache/doris/pull/61678#issuecomment-4154139209
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/61678_2419829ded75b99e9e40c4c9a928dcd0b7266a78_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/61678_2419829ded75b99e9e40c4c9a928dcd0b7266a78_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.27% (27063/36937) |
| Line Coverage | 56.83% (291070/512144) |
| Region Coverage | 54.03% (242186/448227) |
| Branch Coverage | 55.72% (105027/188479) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](code) Add comments and benchmarks for ColumnView. [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt merged PR #61678:
URL: https://github.com/apache/doris/pull/61678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](code) Add comments and benchmarks for ColumnView. [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #61678:
URL: https://github.com/apache/doris/pull/61678#issuecomment-4116927102
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](code) Add comments and benchmarks for ColumnView. [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #61678:
URL: https://github.com/apache/doris/pull/61678#issuecomment-4116852706
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](code) Add comments and benchmarks for ColumnView. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61678:
URL: https://github.com/apache/doris/pull/61678#issuecomment-4153877813
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/61678_2419829ded75b99e9e40c4c9a928dcd0b7266a78_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/61678_2419829ded75b99e9e40c4c9a928dcd0b7266a78_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 70.92% (26149/36872) |
| Line Coverage | 53.46% (271805/508400) |
| Region Coverage | 50.40% (223926/444267) |
| Branch Coverage | 51.56% (96116/186419) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](code) Add comments and benchmarks for ColumnView. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61678:
URL: https://github.com/apache/doris/pull/61678#issuecomment-4153343586
<details>
<summary>TPC-H: <b>Total hot run time: 26829 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2419829ded75b99e9e40c4c9a928dcd0b7266a78, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17613 4535 4302 4302
q2 q3 10638 803 544 544
q4 4675 352 249 249
q5 7613 1230 1020 1020
q6 178 173 145 145
q7 803 850 690 690
q8 9995 1493 1340 1340
q9 5838 4832 4731 4731
q10 6335 1977 1652 1652
q11 470 242 235 235
q12 744 577 468 468
q13 18055 2721 1931 1931
q14 230 237 215 215
q15 q16 743 740 661 661
q17 743 849 458 458
q18 5881 5488 5216 5216
q19 1113 980 634 634
q20 526 501 376 376
q21 4414 1827 1680 1680
q22 412 336 282 282
Total cold run time: 97019 ms
Total hot run time: 26829 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4708 4572 4739 4572
q2 q3 3898 4360 3830 3830
q4 924 1228 786 786
q5 4052 4387 4389 4387
q6 192 178 149 149
q7 1757 1630 1528 1528
q8 2483 2749 2705 2705
q9 7579 7428 7343 7343
q10 3779 4034 3703 3703
q11 525 480 425 425
q12 488 578 440 440
q13 2491 3012 2040 2040
q14 299 309 285 285
q15 q16 724 756 727 727
q17 1434 1386 1382 1382
q18 7366 6847 6834 6834
q19 938 902 923 902
q20 2099 2157 1985 1985
q21 3996 3483 3347 3347
q22 482 432 400 400
Total cold run time: 50214 ms
Total hot run time: 47770 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](code) Add comments and benchmarks for ColumnView. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61678:
URL: https://github.com/apache/doris/pull/61678#issuecomment-4124829133
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/61678_2419829ded75b99e9e40c4c9a928dcd0b7266a78_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/61678_2419829ded75b99e9e40c4c9a928dcd0b7266a78_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.55% (26357/36836) |
| Line Coverage | 54.44% (277372/509535) |
| Region Coverage | 51.54% (229678/445627) |
| Branch Coverage | 53.06% (99193/186936) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](code) Add comments and benchmarks for ColumnView. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61678:
URL: https://github.com/apache/doris/pull/61678#issuecomment-4124141792
<details>
<summary>TPC-H: <b>Total hot run time: 26489 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2419829ded75b99e9e40c4c9a928dcd0b7266a78, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17582 4434 4302 4302
q2 q3 10643 790 521 521
q4 4683 361 248 248
q5 7559 1222 1036 1036
q6 178 172 149 149
q7 789 859 671 671
q8 9304 1493 1345 1345
q9 4923 4601 4708 4601
q10 6251 1919 1658 1658
q11 470 261 250 250
q12 685 577 466 466
q13 18034 2695 1943 1943
q14 229 231 225 225
q15 q16 709 712 665 665
q17 726 824 468 468
q18 5974 5339 5258 5258
q19 1254 986 611 611
q20 536 486 379 379
q21 4637 1859 1407 1407
q22 348 286 431 286
Total cold run time: 95514 ms
Total hot run time: 26489 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4841 4741 4635 4635
q2 q3 3923 4381 3829 3829
q4 887 1190 770 770
q5 4068 4360 4376 4360
q6 190 175 143 143
q7 1776 1677 1543 1543
q8 2476 2693 2585 2585
q9 7955 7300 7273 7273
q10 3864 4008 3625 3625
q11 505 442 408 408
q12 494 589 442 442
q13 2469 2940 2143 2143
q14 287 316 291 291
q15 q16 754 777 748 748
q17 1174 1381 1321 1321
q18 7083 6882 6673 6673
q19 933 908 930 908
q20 2090 2217 1992 1992
q21 3930 3464 3335 3335
q22 446 456 435 435
Total cold run time: 50145 ms
Total hot run time: 47459 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org