[GitHub] [helix] narendly commented on a diff in pull request #2032: Code refactor and cleanup on instance validation

[GitBox <gi...@apache.org>]

narendly commented on code in PR #2032:
URL: https://github.com/apache/helix/pull/2032#discussion_r848701300


##########
helix-core/src/main/java/org/apache/helix/util/InstanceValidationUtil.java:
##########
@@ -138,12 +149,10 @@ public static boolean isAlive(HelixDataAccessor dataAccessor, String instanceNam
    * Method to check if the instance is assigned at least 1 resource, not in a idle state;
    * Independent of the instance alive/enabled status
    * @param dataAccessor
-   * @param clusterId
    * @param instanceName
    * @return
    */
-  public static boolean hasResourceAssigned(HelixDataAccessor dataAccessor, String clusterId,
-      String instanceName) {
+  public static boolean hasResourceAssigned(HelixDataAccessor dataAccessor, String instanceName) {

Review Comment:
   Since this is a public method, can we consider deprecating it and re-creating the version without `clusterId` as an argument?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org