You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/05/24 02:33:38 UTC
[GitHub] [incubator-inlong] Greedyu commented on a diff in pull request #4291: [INLONG-4232][Manager] Support collect data from a specified position for MySQL binlog
Greedyu commented on code in PR #4291:
URL: https://github.com/apache/incubator-inlong/pull/4291#discussion_r880003885
##########
inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/source/MySQLBinlogSource.java:
##########
@@ -100,4 +100,10 @@ public class MySQLBinlogSource extends StreamSource {
@ApiModelProperty(value = "Primary key must be shared by all tables", required = false)
private String primaryKey;
+
+ @ApiModelProperty("Directly read binlog from the specified offset filename")
+ public String specificOffsetFile;
Review Comment:
Referring to the names used by Flink CDC are specificOffsetFile and specificOffsetPos, and the agent module also uses this name.
##########
inlong-manager/manager-client-tools/src/main/java/org/apache/inlong/manager/client/cli/CommandCreate.java:
##########
@@ -71,7 +71,7 @@ void run() {
}
} catch (Exception e) {
System.out.println("Create group failed!");
- System.out.println(e.getMessage());
Review Comment:
The main reason is that the e.getMessage() method cannot see the abnormal link, and the abnormal information is not enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org