You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2022/01/04 22:55:03 UTC

[GitHub] [tinkerpop] xiazcy opened a new pull request #1534: TINKERPOP-2569: Additional Fixes

xiazcy opened a new pull request #1534:
URL: https://github.com/apache/tinkerpop/pull/1534


   Additional minor fixes for https://issues.apache.org/jira/browse/TINKERPOP-2569 based on comments in https://github.com/apache/tinkerpop/pull/1476. 
   
   Added user friendly message in Gremlin console when creating remote connection to hosts that are unavailable.
   Added a `remote.close()` in `RemoteCommand.groovy` when `RemoteException` are thrown during connection in `do_connect` to fix possible leak. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] spmallette merged pull request #1534: TINKERPOP-2569: Additional Fixes

Posted by GitBox <gi...@apache.org>.
spmallette merged pull request #1534:
URL: https://github.com/apache/tinkerpop/pull/1534


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] xiazcy closed pull request #1534: TINKERPOP-2569: Additional Fixes

Posted by GitBox <gi...@apache.org>.
xiazcy closed pull request #1534:
URL: https://github.com/apache/tinkerpop/pull/1534


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] lyndonb-bq commented on a change in pull request #1534: TINKERPOP-2569: Additional Fixes

Posted by GitBox <gi...@apache.org>.
lyndonb-bq commented on a change in pull request #1534:
URL: https://github.com/apache/tinkerpop/pull/1534#discussion_r773452908



##########
File path: gremlin-console/src/test/java/org/apache/tinkerpop/gremlin/console/jsr223/DriverRemoteAcceptorTest.java
##########
@@ -28,9 +28,12 @@
 
 import java.util.ArrayList;
 import java.util.Arrays;
+import java.util.Collections;

Review comment:
       ```suggestion
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] spmallette commented on pull request #1534: TINKERPOP-2569: Additional Fixes

Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1534:
URL: https://github.com/apache/tinkerpop/pull/1534#issuecomment-1002795401


   could you please rebase on 3.4-dev when you have a moment? doing so should resolve the gremlin-server CI failure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] spmallette commented on pull request #1534: TINKERPOP-2569: Additional Fixes

Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1534:
URL: https://github.com/apache/tinkerpop/pull/1534#issuecomment-1006212524


   Thanks for this follow-on work - merged!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org