You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by "William A. Rowe, Jr." <wr...@rowe-clan.net> on 2000/12/30 05:43:16 UTC
FW: cvs commit: httpd-docs-1.3/htdocs/manual index.html.en index.html.ja.jis
Duh...
wrowe 00/12/29 20:09:10
Modified: htdocs/manual index.html.en index.html.ja.jis
Log:
Credit to Carol Compton <cc...@covalent.net> for finding this bug in
our html, and thanks to Dirk for kindly restating all the obvious bits.
Dunno how long this was broken, but it must have been coded by a
javascripter ... buttons that go nowhere :-)
Revision Changes Path
1.45 +2 -2 httpd-docs-1.3/htdocs/manual/index.html.en
Index: index.html.en
===================================================================
RCS file: /home/cvs/httpd-docs-1.3/htdocs/manual/index.html.en,v
retrieving revision 1.44
retrieving revision 1.45
diff -u -r1.44 -r1.45
--- index.html.en 2000/12/29 23:34:37 1.44
+++ index.html.en 2000/12/30 04:09:09 1.45
@@ -48,11 +48,11 @@
<table cellspacing="0" cellpadding="0" border="0" width="600">
<tr><td align="center">
- <form method="POST" action="http://search.apache.org/">
+ <form method="post" action="http://search.apache.org/">
<input type="hidden" name="what" value="ap">
<input type="hidden" name="results" value="20">
<input type="text" name="keyword" size="20">
- <input type="button" value="Search">
+ <input type="submit" value="Search">
</form>
</td></tr></table>
1.5 +1 -1 httpd-docs-1.3/htdocs/manual/index.html.ja.jis
Index: index.html.ja.jis
===================================================================
RCS file: /home/cvs/httpd-docs-1.3/htdocs/manual/index.html.ja.jis,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- index.html.ja.jis 2000/12/30 02:52:27 1.4
+++ index.html.ja.jis 2000/12/30 04:09:09 1.5
@@ -52,7 +52,7 @@
<input type="hidden" name="what" value="ap">
<input type="hidden" name="results" value="20">
<input type="text" name="keyword" size="20">
- <input type="button" value="Search">
+ <input type="submit" value="Search">
</form>
</td></tr></table>
Re: FW: cvs commit: httpd-docs-1.3/htdocs/manual index.html.en index.html.ja.jis
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
This was a non-issue.
The script was being launched by an <INPUT type=button> with
no action, ergo no search. Obviously coded by a javascripter
who had no java. Patching to <INPUT type=submit> worked fine.
As always, its the obvious stuff that'll kill ya
----- Original Message -----
From: "Rodent of Unusual Size" <Ke...@Golux.Com>
To: <ne...@apache.org>
Sent: Tuesday, January 09, 2001 3:21 PM
Subject: Re: FW: cvs commit: httpd-docs-1.3/htdocs/manual index.html.en index.html.ja.jis
> "William A. Rowe, Jr." wrote:
> >
> > By the html spec "post" is legal, by the http spec, only "POST"
> > is legal
>
> Both are legal. Since the method is case-sensitive, they are not
> identical. The issue is that semantics for 'POST' are defined,
> but 'post' is a random extension method.
> --
> #ken P-)}
>
> Ken Coar <http://Golux.Com/coar/>
> Apache Software Foundation <http://www.apache.org/>
> "Apache Server for Dummies" <http://Apache-Server.Com/>
> "Apache Server Unleashed" <http://ApacheUnleashed.Com/>
>
Re: FW: cvs commit: httpd-docs-1.3/htdocs/manual index.html.en
index.html.ja.jis
Posted by Rodent of Unusual Size <Ke...@Golux.Com>.
"William A. Rowe, Jr." wrote:
>
> By the html spec "post" is legal, by the http spec, only "POST"
> is legal
Both are legal. Since the method is case-sensitive, they are not
identical. The issue is that semantics for 'POST' are defined,
but 'post' is a random extension method.
--
#ken P-)}
Ken Coar <http://Golux.Com/coar/>
Apache Software Foundation <http://www.apache.org/>
"Apache Server for Dummies" <http://Apache-Server.Com/>
"Apache Server Unleashed" <http://ApacheUnleashed.Com/>
RE: FW: cvs commit: httpd-docs-1.3/htdocs/manual index.html.en index.html.ja.jis
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
> From: Roy T. Fielding [mailto:fielding@ebuilt.com]
> Sent: Friday, December 29, 2000 10:50 PM
>
> > - <form method="POST" action="http://search.apache.org/">
> > + <form method="post" action="http://search.apache.org/">
>
> As Dirk mentioned, this is just wrong. Are you in the midst of
> globally replacing it or something? The method must be POST.
By the html spec "post" is legal, by the http spec, only "POST"
is legal, it is the responsibility of the client to submit legal
html to the httpd server. Dirk's point was that "post" is completely
legal in the html. He was saying the script should never test for
anything but "POST" since it better be in that explicit case by the
time the client and server are done with it.
First issue, "POST" isn't necessarily so in jis encoding. I backed
that out till someone with iso-2022-jp could look at the issue.
Then I backed out the en encoding change as well. The real problem?
<input type="button"> rather than <input type="submit">.
Goes to show, always look for the obvious first. Since I'm naturally
a keyboard user, I would never catch this sort of thing ... and
apparently noone else did, either :-(
Re: FW: cvs commit: httpd-docs-1.3/htdocs/manual index.html.en index.html.ja.jis
Posted by "Roy T. Fielding" <fi...@ebuilt.com>.
> - <form method="POST" action="http://search.apache.org/">
> + <form method="post" action="http://search.apache.org/">
As Dirk mentioned, this is just wrong. Are you in the midst of
globally replacing it or something? The method must be POST.
....Roy