You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by "Willi Schönborn (JIRA)" <de...@velocity.apache.org> on 2010/01/10 17:13:54 UTC
[jira] Created: (VELOCITY-751) CLONE -Remove "Exception" type
throwing.
CLONE -Remove "Exception" type throwing.
----------------------------------------
Key: VELOCITY-751
URL: https://issues.apache.org/jira/browse/VELOCITY-751
Project: Velocity
Issue Type: Improvement
Components: Engine
Environment: NA
Reporter: Willi Schönborn
Priority: Trivial
Fix For: 1.5
I have to use Checkstyle coding standards at my job. Some methos of Velocity throw exceptions using the raw "Exception" type. So Checkstyle points an error everywhere I use Velocity and, unfortunately, that's a fact I cannot override in my source code. So it would be nice if those "throws Exception" are replaced by some Velocity proper exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Reopened: (VELOCITY-751) CLONE -Remove "Exception" type
throwing.
Posted by "Nathan Bubna (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nathan Bubna reopened VELOCITY-751:
-----------------------------------
Re-opening since not all are fixed yet...
> CLONE -Remove "Exception" type throwing.
> ----------------------------------------
>
> Key: VELOCITY-751
> URL: https://issues.apache.org/jira/browse/VELOCITY-751
> Project: Velocity
> Issue Type: Improvement
> Components: Engine
> Affects Versions: 1.6.2
> Environment: NA
> Reporter: Willi Schönborn
> Fix For: 1.7, 2.0
>
> Attachments: velocity-751-exception-fixes.patch
>
>
> I have to use Checkstyle coding standards at my job. Some methos of Velocity throw exceptions using the raw "Exception" type. So Checkstyle points an error everywhere I use Velocity and, unfortunately, that's a fact I cannot override in my source code. So it would be nice if those "throws Exception" are replaced by some Velocity proper exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Resolved: (VELOCITY-751) CLONE -Remove "Exception" type
throwing.
Posted by "Nathan Bubna (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nathan Bubna resolved VELOCITY-751.
-----------------------------------
Resolution: Fixed
Fix Version/s: 2.0
1.7
thanks again, Jarkko!
> CLONE -Remove "Exception" type throwing.
> ----------------------------------------
>
> Key: VELOCITY-751
> URL: https://issues.apache.org/jira/browse/VELOCITY-751
> Project: Velocity
> Issue Type: Improvement
> Components: Engine
> Affects Versions: 1.6.2
> Environment: NA
> Reporter: Willi Schönborn
> Fix For: 1.7, 2.0
>
> Attachments: velocity-751-exception-fixes.patch
>
>
> I have to use Checkstyle coding standards at my job. Some methos of Velocity throw exceptions using the raw "Exception" type. So Checkstyle points an error everywhere I use Velocity and, unfortunately, that's a fact I cannot override in my source code. So it would be nice if those "throws Exception" are replaced by some Velocity proper exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Resolved: (VELOCITY-751) CLONE -Remove "Exception" type
throwing.
Posted by "Nathan Bubna (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nathan Bubna resolved VELOCITY-751.
-----------------------------------
Resolution: Fixed
Ok, i think this is about as fixed as we can reasonably make it for the 1.x family, due to backwards compatibility concerns. If you see other places, please correct me.
And i've completely fixed this (i think) in 2.0, where we aren't concerned about backwards compatibility.
> CLONE -Remove "Exception" type throwing.
> ----------------------------------------
>
> Key: VELOCITY-751
> URL: https://issues.apache.org/jira/browse/VELOCITY-751
> Project: Velocity
> Issue Type: Improvement
> Components: Engine
> Affects Versions: 1.6.2
> Environment: NA
> Reporter: Willi Schönborn
> Fix For: 1.7, 2.0
>
> Attachments: velocity-751-exception-fixes.patch
>
>
> I have to use Checkstyle coding standards at my job. Some methos of Velocity throw exceptions using the raw "Exception" type. So Checkstyle points an error everywhere I use Velocity and, unfortunately, that's a fact I cannot override in my source code. So it would be nice if those "throws Exception" are replaced by some Velocity proper exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Updated: (VELOCITY-751) CLONE -Remove "Exception" type
throwing.
Posted by "Willi Schönborn (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willi Schönborn updated VELOCITY-751:
-------------------------------------
Fix Version/s: (was: 1.5)
Priority: Major (was: Trivial)
Affects Version/s: 1.6.2
> CLONE -Remove "Exception" type throwing.
> ----------------------------------------
>
> Key: VELOCITY-751
> URL: https://issues.apache.org/jira/browse/VELOCITY-751
> Project: Velocity
> Issue Type: Improvement
> Components: Engine
> Affects Versions: 1.6.2
> Environment: NA
> Reporter: Willi Schönborn
>
> I have to use Checkstyle coding standards at my job. Some methos of Velocity throw exceptions using the raw "Exception" type. So Checkstyle points an error everywhere I use Velocity and, unfortunately, that's a fact I cannot override in my source code. So it would be nice if those "throws Exception" are replaced by some Velocity proper exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Updated: (VELOCITY-751) CLONE -Remove "Exception" type
throwing.
Posted by "Jarkko Viinamäki (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jarkko Viinamäki updated VELOCITY-751:
--------------------------------------
Attachment: velocity-751-exception-fixes.patch
The current SVN trunk (head) has most "throws Exception" things removed but there were a few left. This patch removes many incorrect JavaDoc @throws statements and modifies some method signatures.
There are also some public interfaces that use "throws Exception" quite extensively. This is obviously bad practice. :(
> CLONE -Remove "Exception" type throwing.
> ----------------------------------------
>
> Key: VELOCITY-751
> URL: https://issues.apache.org/jira/browse/VELOCITY-751
> Project: Velocity
> Issue Type: Improvement
> Components: Engine
> Affects Versions: 1.6.2
> Environment: NA
> Reporter: Willi Schönborn
> Attachments: velocity-751-exception-fixes.patch
>
>
> I have to use Checkstyle coding standards at my job. Some methos of Velocity throw exceptions using the raw "Exception" type. So Checkstyle points an error everywhere I use Velocity and, unfortunately, that's a fact I cannot override in my source code. So it would be nice if those "throws Exception" are replaced by some Velocity proper exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELOCITY-751) CLONE -Remove "Exception" type
throwing.
Posted by "Willi Schönborn (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798498#action_12798498 ]
Willi Schönborn commented on VELOCITY-751:
------------------------------------------
I made a clone of this old issue because there are still a lot of places where a java.lang.Exception is thrown.
E.g.:
- http://velocity.apache.org/engine/releases/velocity-1.6.2/apidocs/org/apache/velocity/app/VelocityEngine.html#init(java.util.Properties)
- http://velocity.apache.org/engine/releases/velocity-1.6.2/apidocs/org/apache/velocity/app/VelocityEngine.html#getTemplate(java.lang.String,%20java.lang.String)
- and many more
> CLONE -Remove "Exception" type throwing.
> ----------------------------------------
>
> Key: VELOCITY-751
> URL: https://issues.apache.org/jira/browse/VELOCITY-751
> Project: Velocity
> Issue Type: Improvement
> Components: Engine
> Environment: NA
> Reporter: Willi Schönborn
> Priority: Trivial
> Fix For: 1.5
>
>
> I have to use Checkstyle coding standards at my job. Some methos of Velocity throw exceptions using the raw "Exception" type. So Checkstyle points an error everywhere I use Velocity and, unfortunately, that's a fact I cannot override in my source code. So it would be nice if those "throws Exception" are replaced by some Velocity proper exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org