You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@ambari.apache.org by Amruta Borkar <ar...@us.ibm.com> on 2017/05/18 18:27:13 UTC

Review Request 59373: Address config-groups while exporting blueprint from UI

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59373/
-----------------------------------------------------------

Review request for Ambari, Alexandr Antonenko, Di Li, Robert Nettleton, and Sangeeta Ravindran.


Bugs: AMBARI-21050
    https://issues.apache.org/jira/browse/AMBARI-21050


Repository: ambari


Description
-------

Exported blueprint should include config-group changes, which should be exported as host-group level configuration. New host-group will be created for host having unique config-group.


Diffs
-----

  ambari-web/app/controllers/wizard/step8_controller.js 7e318e0e62 
  ambari-web/test/controllers/wizard/step8_test.js 1a3214e263 


Diff: https://reviews.apache.org/r/59373/diff/1/


Testing
-------

Tested manually. Updated test cases.


File Attachments
----------------

exported blueprint
  https://reviews.apache.org/media/uploaded/files/2017/05/18/a01c8336-2e84-4c73-af54-c7ba60e7acb3__blueprint_expUI.json
exported cluster template
  https://reviews.apache.org/media/uploaded/files/2017/05/18/ee8f7e71-fea9-42ba-bcd1-9afc1a8654d6__clustertemplate_expUI.json


Thanks,

Amruta Borkar

Re: Review Request 59373: Address config-groups while exporting blueprint from UI

Posted by Di Li <di...@ca.ibm.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59373/#review175797
-----------------------------------------------------------


Ship it!




Ship It!

- Di Li


On May 19, 2017, 5:01 p.m., Amruta Borkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59373/
> -----------------------------------------------------------
> 
> (Updated May 19, 2017, 5:01 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Di Li, Robert Nettleton, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-21050
>     https://issues.apache.org/jira/browse/AMBARI-21050
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Exported blueprint should include config-group changes, which should be exported as host-group level configuration. New host-group will be created for host having unique config-group.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/wizard/step8_controller.js 7e318e0e62 
>   ambari-web/test/controllers/wizard/step8_test.js 1a3214e263 
> 
> 
> Diff: https://reviews.apache.org/r/59373/diff/2/
> 
> 
> Testing
> -------
> 
> Tested manually. Updated test cases.
> 
> 
> File Attachments
> ----------------
> 
> exported blueprint
>   https://reviews.apache.org/media/uploaded/files/2017/05/18/a01c8336-2e84-4c73-af54-c7ba60e7acb3__blueprint_expUI.json
> exported cluster template
>   https://reviews.apache.org/media/uploaded/files/2017/05/18/ee8f7e71-fea9-42ba-bcd1-9afc1a8654d6__clustertemplate_expUI.json
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 59373: Address config-groups while exporting blueprint from UI

Posted by Sangeeta Ravindran <sa...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59373/#review175527
-----------------------------------------------------------


Ship it!




Ship It!

- Sangeeta Ravindran


On May 19, 2017, 5:01 p.m., Amruta Borkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59373/
> -----------------------------------------------------------
> 
> (Updated May 19, 2017, 5:01 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Di Li, Robert Nettleton, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-21050
>     https://issues.apache.org/jira/browse/AMBARI-21050
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Exported blueprint should include config-group changes, which should be exported as host-group level configuration. New host-group will be created for host having unique config-group.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/wizard/step8_controller.js 7e318e0e62 
>   ambari-web/test/controllers/wizard/step8_test.js 1a3214e263 
> 
> 
> Diff: https://reviews.apache.org/r/59373/diff/2/
> 
> 
> Testing
> -------
> 
> Tested manually. Updated test cases.
> 
> 
> File Attachments
> ----------------
> 
> exported blueprint
>   https://reviews.apache.org/media/uploaded/files/2017/05/18/a01c8336-2e84-4c73-af54-c7ba60e7acb3__blueprint_expUI.json
> exported cluster template
>   https://reviews.apache.org/media/uploaded/files/2017/05/18/ee8f7e71-fea9-42ba-bcd1-9afc1a8654d6__clustertemplate_expUI.json
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 59373: Address config-groups while exporting blueprint from UI

Posted by Amruta Borkar <ar...@us.ibm.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59373/
-----------------------------------------------------------

(Updated May 19, 2017, 5:01 p.m.)


Review request for Ambari, Alexandr Antonenko, Di Li, Robert Nettleton, and Sangeeta Ravindran.


Bugs: AMBARI-21050
    https://issues.apache.org/jira/browse/AMBARI-21050


Repository: ambari


Description
-------

Exported blueprint should include config-group changes, which should be exported as host-group level configuration. New host-group will be created for host having unique config-group.


Diffs (updated)
-----

  ambari-web/app/controllers/wizard/step8_controller.js 7e318e0e62 
  ambari-web/test/controllers/wizard/step8_test.js 1a3214e263 


Diff: https://reviews.apache.org/r/59373/diff/2/

Changes: https://reviews.apache.org/r/59373/diff/1-2/


Testing
-------

Tested manually. Updated test cases.


File Attachments
----------------

exported blueprint
  https://reviews.apache.org/media/uploaded/files/2017/05/18/a01c8336-2e84-4c73-af54-c7ba60e7acb3__blueprint_expUI.json
exported cluster template
  https://reviews.apache.org/media/uploaded/files/2017/05/18/ee8f7e71-fea9-42ba-bcd1-9afc1a8654d6__clustertemplate_expUI.json


Thanks,

Amruta Borkar

Re: Review Request 59373: Address config-groups while exporting blueprint from UI

Posted by Alexandr Antonenko <hi...@gmail.com>.


> On May 19, 2017, 8:28 a.m., Alexandr Antonenko wrote:
> > Ship It!
> 
> Amruta Borkar wrote:
>     Hello Alexandr,
>     Could you please help me push this to trunk?

committed to trunk


- Alexandr


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59373/#review175476
-----------------------------------------------------------


On May 19, 2017, 5:01 p.m., Amruta Borkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59373/
> -----------------------------------------------------------
> 
> (Updated May 19, 2017, 5:01 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Di Li, Robert Nettleton, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-21050
>     https://issues.apache.org/jira/browse/AMBARI-21050
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Exported blueprint should include config-group changes, which should be exported as host-group level configuration. New host-group will be created for host having unique config-group.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/wizard/step8_controller.js 7e318e0e62 
>   ambari-web/test/controllers/wizard/step8_test.js 1a3214e263 
> 
> 
> Diff: https://reviews.apache.org/r/59373/diff/2/
> 
> 
> Testing
> -------
> 
> Tested manually. Updated test cases.
> 
> 
> File Attachments
> ----------------
> 
> exported blueprint
>   https://reviews.apache.org/media/uploaded/files/2017/05/18/a01c8336-2e84-4c73-af54-c7ba60e7acb3__blueprint_expUI.json
> exported cluster template
>   https://reviews.apache.org/media/uploaded/files/2017/05/18/ee8f7e71-fea9-42ba-bcd1-9afc1a8654d6__clustertemplate_expUI.json
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 59373: Address config-groups while exporting blueprint from UI

Posted by Amruta Borkar <ar...@us.ibm.com>.


> On May 19, 2017, 8:28 a.m., Alexandr Antonenko wrote:
> > Ship It!

Hello Alexandr,
Could you please help me push this to trunk?


- Amruta


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59373/#review175476
-----------------------------------------------------------


On May 19, 2017, 5:01 p.m., Amruta Borkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59373/
> -----------------------------------------------------------
> 
> (Updated May 19, 2017, 5:01 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Di Li, Robert Nettleton, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-21050
>     https://issues.apache.org/jira/browse/AMBARI-21050
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Exported blueprint should include config-group changes, which should be exported as host-group level configuration. New host-group will be created for host having unique config-group.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/wizard/step8_controller.js 7e318e0e62 
>   ambari-web/test/controllers/wizard/step8_test.js 1a3214e263 
> 
> 
> Diff: https://reviews.apache.org/r/59373/diff/2/
> 
> 
> Testing
> -------
> 
> Tested manually. Updated test cases.
> 
> 
> File Attachments
> ----------------
> 
> exported blueprint
>   https://reviews.apache.org/media/uploaded/files/2017/05/18/a01c8336-2e84-4c73-af54-c7ba60e7acb3__blueprint_expUI.json
> exported cluster template
>   https://reviews.apache.org/media/uploaded/files/2017/05/18/ee8f7e71-fea9-42ba-bcd1-9afc1a8654d6__clustertemplate_expUI.json
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 59373: Address config-groups while exporting blueprint from UI

Posted by Alexandr Antonenko <hi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59373/#review175476
-----------------------------------------------------------


Ship it!




Ship It!

- Alexandr Antonenko


On May 18, 2017, 6:27 p.m., Amruta Borkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59373/
> -----------------------------------------------------------
> 
> (Updated May 18, 2017, 6:27 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Di Li, Robert Nettleton, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-21050
>     https://issues.apache.org/jira/browse/AMBARI-21050
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Exported blueprint should include config-group changes, which should be exported as host-group level configuration. New host-group will be created for host having unique config-group.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/wizard/step8_controller.js 7e318e0e62 
>   ambari-web/test/controllers/wizard/step8_test.js 1a3214e263 
> 
> 
> Diff: https://reviews.apache.org/r/59373/diff/1/
> 
> 
> Testing
> -------
> 
> Tested manually. Updated test cases.
> 
> 
> File Attachments
> ----------------
> 
> exported blueprint
>   https://reviews.apache.org/media/uploaded/files/2017/05/18/a01c8336-2e84-4c73-af54-c7ba60e7acb3__blueprint_expUI.json
> exported cluster template
>   https://reviews.apache.org/media/uploaded/files/2017/05/18/ee8f7e71-fea9-42ba-bcd1-9afc1a8654d6__clustertemplate_expUI.json
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 59373: Address config-groups while exporting blueprint from UI

Posted by Di Li <di...@ca.ibm.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59373/#review175502
-----------------------------------------------------------




ambari-web/test/controllers/wizard/step8_test.js
Line 2346 (original), 2343 (patched)
<https://reviews.apache.org/r/59373/#comment248938>

    minor: remove console.log from tests


- Di Li


On May 18, 2017, 6:27 p.m., Amruta Borkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59373/
> -----------------------------------------------------------
> 
> (Updated May 18, 2017, 6:27 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Di Li, Robert Nettleton, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-21050
>     https://issues.apache.org/jira/browse/AMBARI-21050
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Exported blueprint should include config-group changes, which should be exported as host-group level configuration. New host-group will be created for host having unique config-group.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/wizard/step8_controller.js 7e318e0e62 
>   ambari-web/test/controllers/wizard/step8_test.js 1a3214e263 
> 
> 
> Diff: https://reviews.apache.org/r/59373/diff/1/
> 
> 
> Testing
> -------
> 
> Tested manually. Updated test cases.
> 
> 
> File Attachments
> ----------------
> 
> exported blueprint
>   https://reviews.apache.org/media/uploaded/files/2017/05/18/a01c8336-2e84-4c73-af54-c7ba60e7acb3__blueprint_expUI.json
> exported cluster template
>   https://reviews.apache.org/media/uploaded/files/2017/05/18/ee8f7e71-fea9-42ba-bcd1-9afc1a8654d6__clustertemplate_expUI.json
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 59373: Address config-groups while exporting blueprint from UI

Posted by Robert Nettleton <rn...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59373/#review175524
-----------------------------------------------------------


Ship it!




Ship It!

- Robert Nettleton


On May 18, 2017, 6:27 p.m., Amruta Borkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59373/
> -----------------------------------------------------------
> 
> (Updated May 18, 2017, 6:27 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Di Li, Robert Nettleton, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-21050
>     https://issues.apache.org/jira/browse/AMBARI-21050
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Exported blueprint should include config-group changes, which should be exported as host-group level configuration. New host-group will be created for host having unique config-group.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/wizard/step8_controller.js 7e318e0e62 
>   ambari-web/test/controllers/wizard/step8_test.js 1a3214e263 
> 
> 
> Diff: https://reviews.apache.org/r/59373/diff/1/
> 
> 
> Testing
> -------
> 
> Tested manually. Updated test cases.
> 
> 
> File Attachments
> ----------------
> 
> exported blueprint
>   https://reviews.apache.org/media/uploaded/files/2017/05/18/a01c8336-2e84-4c73-af54-c7ba60e7acb3__blueprint_expUI.json
> exported cluster template
>   https://reviews.apache.org/media/uploaded/files/2017/05/18/ee8f7e71-fea9-42ba-bcd1-9afc1a8654d6__clustertemplate_expUI.json
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>