You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Koushik Das <ko...@citrix.com> on 2012/07/03 17:46:02 UTC
Review Request: Fix for CS-15279
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5719/
-----------------------------------------------------------
Review request for cloudstack, Prachi Damle and Nitin Mehta.
Description
-------
Issue happens when ROOT volume gets created and there is subsequent failure in starting the VM. During retry if allocator assigns a different storage pool the scenario was not handled. Now in case of local storage the volume get recreated on the newly assigned pool and old one gets cleaned up. In case of shared storage the existing volume is migrated to new storage pool.
Diffs
-----
server/src/com/cloud/storage/StorageManagerImpl.java 3fe27ae
Diff: https://reviews.apache.org/r/5719/diff/
Testing
-------
Yes
Thanks,
Koushik Das
Re: Review Request: Fix for CS-15279
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5719/#review9023
-----------------------------------------------------------
Ship it!
Ship It!
- Nitin Mehta
On July 3, 2012, 3:46 p.m., Koushik Das wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5719/
> -----------------------------------------------------------
>
> (Updated July 3, 2012, 3:46 p.m.)
>
>
> Review request for cloudstack, Prachi Damle and Nitin Mehta.
>
>
> Description
> -------
>
> Issue happens when ROOT volume gets created and there is subsequent failure in starting the VM. During retry if allocator assigns a different storage pool the scenario was not handled. Now in case of local storage the volume get recreated on the newly assigned pool and old one gets cleaned up. In case of shared storage the existing volume is migrated to new storage pool.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/StorageManagerImpl.java 3fe27ae
>
> Diff: https://reviews.apache.org/r/5719/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Koushik Das
>
>
Re: Review Request: Fix for CS-15279
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5719/#review9022
-----------------------------------------------------------
Ship it!
Ship It!
- Nitin Mehta
On July 3, 2012, 3:46 p.m., Koushik Das wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5719/
> -----------------------------------------------------------
>
> (Updated July 3, 2012, 3:46 p.m.)
>
>
> Review request for cloudstack, Prachi Damle and Nitin Mehta.
>
>
> Description
> -------
>
> Issue happens when ROOT volume gets created and there is subsequent failure in starting the VM. During retry if allocator assigns a different storage pool the scenario was not handled. Now in case of local storage the volume get recreated on the newly assigned pool and old one gets cleaned up. In case of shared storage the existing volume is migrated to new storage pool.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/StorageManagerImpl.java 3fe27ae
>
> Diff: https://reviews.apache.org/r/5719/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Koushik Das
>
>
Re: Review Request: Fix for CS-15279
Posted by Prachi Damle <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5719/#review9367
-----------------------------------------------------------
Ship it!
This looks good. Will apply the patch.
- Prachi Damle
On July 3, 2012, 3:46 p.m., Koushik Das wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5719/
> -----------------------------------------------------------
>
> (Updated July 3, 2012, 3:46 p.m.)
>
>
> Review request for cloudstack, Prachi Damle and Nitin Mehta.
>
>
> Description
> -------
>
> Issue happens when ROOT volume gets created and there is subsequent failure in starting the VM. During retry if allocator assigns a different storage pool the scenario was not handled. Now in case of local storage the volume get recreated on the newly assigned pool and old one gets cleaned up. In case of shared storage the existing volume is migrated to new storage pool.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/StorageManagerImpl.java 3fe27ae
>
> Diff: https://reviews.apache.org/r/5719/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Koushik Das
>
>