You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2017/11/12 23:36:14 UTC
[GitHub] spark pull request #19640: [SPARK-16986][WEB-UI] Converter Started, Complete...
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19640#discussion_r150428853
--- Diff: core/src/main/resources/org/apache/spark/ui/static/historypage.js ---
@@ -38,8 +38,17 @@ function makeIdNumeric(id) {
}
function formatDate(date) {
- if (date <= 0) return "-";
- else return date.split(".")[0].replace("T", " ");
+ if (date <= 0) {
+ return "-";
--- End diff --
just for curious, what does a single `-` mean here? invalid value?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org