You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by clebertsuconic <gi...@git.apache.org> on 2016/04/28 00:08:53 UTC
[GitHub] activemq-artemis pull request: Individualizing logger.traces on se...
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/494
Individualizing logger.traces on server
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clebertsuconic/activemq-artemis server-logger
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/494.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #494
----
commit 95907252b5dac23db32e6586d1d2631f9624d335
Author: Clebert Suconic <cl...@apache.org>
Date: 2016-04-27T22:01:41Z
Individualizing logger.traces on org.apache.activemq.artemis.core.server (artemis-server project)
This makes it easier to debug through loggers
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Individualizing logger.traces on se...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/494#issuecomment-215512380
@mtaylor I have done some changes after talking to jamezp
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Individualizing logger.traces on se...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/494
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Individualizing logger.traces on se...
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the pull request:
https://github.com/apache/activemq-artemis/pull/494#issuecomment-215414168
@clebertsuconic I see what you are trying to achieve here. But, the JIT compiler would likely remove any string creation and method calls after it realises that the branch is never reached. Do you have any benchmark/test you are using to see if this makes any form of performance increase? I think it's worth investigating before we start polluting the code with all these, if(isTrace) statements.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Individualizing logger.traces on se...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/494#issuecomment-215417342
@mtaylor I haven't changed anything in that regard...
the if (isTrace) is something we have done since the ancient days... all I did was to individualize the loggers:
if you called log.trace("a" + "b" + integerSomething");
the string will be concatenated.. sent down to log.trace to only be reject in case it was not traced.
In some cases we do quite a lot of traces.. at a very down level.. so that would definitely be relevant.
It is really costly... but as I said.. I didn't change anything.. we were already checking if (isTrace) some way or the other here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Individualizing logger.traces on se...
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the pull request:
https://github.com/apache/activemq-artemis/pull/494#issuecomment-215425678
@clebertsuconic I see you're not actually adding isTrace here. Just refactoring what is already there. I made the assumption due to our previous conversation. I'll merge this, I just wonder if this pattern is still relevant with cool stuff the JIT compiler can now do. It might be worth testing/benchmarking before wrapping all our log statements. I'll merge this as is. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---