You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Szilard Nemeth (JIRA)" <ji...@apache.org> on 2018/08/01 08:37:00 UTC
[jira] [Commented] (YARN-7948) Enable refreshing maximum allocation
for multiple resource types
[ https://issues.apache.org/jira/browse/YARN-7948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564965#comment-16564965 ]
Szilard Nemeth commented on YARN-7948:
--------------------------------------
Thanks [~haibochen] for your review comments!
1. Yep, I agree that the way TestCapacityScheduler declared resource types are more readable than my version.
Please keep in mind though that some initialization for the custom resources should be taken care of, see the method {{initResourceTypes}}
2. Removed the resourcemanager field and all of its usages.
3. Default resources (cpu, memory) are already covered in my testcase in patch002 so I haven't modified this part.
4. I cannot see any unused imports in TestFairScheduler in patch002, either.
> Enable refreshing maximum allocation for multiple resource types
> ----------------------------------------------------------------
>
> Key: YARN-7948
> URL: https://issues.apache.org/jira/browse/YARN-7948
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
> Affects Versions: 3.0.0
> Reporter: Yufei Gu
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: YARN-7948.001.patch, YARN-7948.002.patch, YARN-7948.003.patch
>
>
> YARN-7738 did the same thing for CS. We need a fix for FS. We could fix it by moving the refresh code from class CS to class AbstractYARNScheduler.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org