You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2020/02/20 14:25:34 UTC
[Impala-ASF-CR] IMPALA-9406 Add some new packages to download
zhaorenhai@hotmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15253
Change subject: IMPALA-9406 Add some new packages to download
......................................................................
IMPALA-9406 Add some new packages to download
Add some new packages to download for supporting arm64,
pkg-config and flex are for building kudu.
And also fixs a minor issue, sometimes the command
'sudo -u postgres psql -c ' will block, reason not found,
add 'timeout 3' to avoid it.
Change-Id: I5b3404b7c067a78689197c774b3b63115ea4339e
---
M bin/bootstrap_system.sh
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/15253/1
--
To view, visit http://gerrit.cloudera.org:8080/15253
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b3404b7c067a78689197c774b3b63115ea4339e
Gerrit-Change-Number: 15253
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
[Impala-ASF-CR] IMPALA-9406 Add some new packages to download
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/15253 )
Change subject: IMPALA-9406 Add some new packages to download
......................................................................
Patch Set 1:
Hey Zhao,
I wonder if this is still necessary. You mention that you need these packages for building Kudu, so I assume you need to build Kudu because the CDH_KUDU and CDP_KUDU are not provided on ARM for you ARM efforts.
However, since commit 14ae6eae1e3e0ff78040ae2bad92d36d745cf365 on master (commit title: "IMPALA-9279: Update the Kudu version to include VARCHAR support") Kudu can be integrated (again) via the toolchain, which may be a cleaner way for you.
Please note that I have no problems adding the packages, I'm just curious about the use case that requires them.
Thanks,
- Laszlo
--
To view, visit http://gerrit.cloudera.org:8080/15253
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b3404b7c067a78689197c774b3b63115ea4339e
Gerrit-Change-Number: 15253
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Sun, 22 Mar 2020 14:59:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9406 Add some new packages to download
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15253 )
Change subject: IMPALA-9406 Add some new packages to download
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15253
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b3404b7c067a78689197c774b3b63115ea4339e
Gerrit-Change-Number: 15253
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2020 12:06:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9406 Add some new packages to download
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has abandoned this change. ( http://gerrit.cloudera.org:8080/15253 )
Change subject: IMPALA-9406 Add some new packages to download
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/15253
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I5b3404b7c067a78689197c774b3b63115ea4339e
Gerrit-Change-Number: 15253
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
[Impala-ASF-CR] IMPALA-9406 Add some new packages to download
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/15253 )
Change subject: IMPALA-9406 Add some new packages to download
......................................................................
Patch Set 1:
Thank you for watching this, Laszlo. Because now, there are no valid and released kudu versions which support aarch64, I need to build it from source code which have been modified for adapting aarch64. Anyway, this commit is not very critical, I can download and install the packages myself. Maybe in future when there is a aarch64 version kudu, this commit is useless, we can just abandon it.
--
To view, visit http://gerrit.cloudera.org:8080/15253
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b3404b7c067a78689197c774b3b63115ea4339e
Gerrit-Change-Number: 15253
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Mon, 23 Mar 2020 01:51:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9406 Add some new packages to download
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/15253 )
Change subject: IMPALA-9406 Add some new packages to download
......................................................................
Patch Set 1:
> Patch Set 1:
>
> Thank you for watching this, Laszlo. Because now, there are no valid and released kudu versions which support aarch64, I need to build it from source code which have been modified for adapting aarch64. Anyway, this commit is not very critical, I can download and install the packages myself. Maybe in future when there is a aarch64 version kudu, this commit is useless, we can just abandon it.
I am not opposing these packages; they are fairly trivial.
I was more interested in your workflow, as you mentioned that you need to build Kudu yourself, given that there is currently no Kudu distribution ready for aarch64.
Given that:
1. Impala usually pulls in Kudu through the native-toolchain project, and since IMPALA-9279 this is again possible for the master branch, and
2. I noticed that there were several commits added to the native-toolchain project targeting aarch64 compatibility,
I thought that maybe the best way to build Kudu would be through the native-toolchain project (which project most likely has these packages too).
Anyway, it is also OK if you follow a staged approach; these packages are unlikely to cause problems.
--
To view, visit http://gerrit.cloudera.org:8080/15253
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b3404b7c067a78689197c774b3b63115ea4339e
Gerrit-Change-Number: 15253
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Thu, 26 Mar 2020 22:01:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9406 Add some new packages to download
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15253 )
Change subject: IMPALA-9406 Add some new packages to download
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5287/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15253
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b3404b7c067a78689197c774b3b63115ea4339e
Gerrit-Change-Number: 15253
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Feb 2020 15:13:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9406 Add some new packages to download
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15253 )
Change subject: IMPALA-9406 Add some new packages to download
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5405/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/15253
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b3404b7c067a78689197c774b3b63115ea4339e
Gerrit-Change-Number: 15253
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2020 07:35:36 +0000
Gerrit-HasComments: No