[GitHub] [airflow] ferruzzi commented on a diff in pull request #32356: D205 Support - Provider: Google

["ferruzzi (via GitHub)" <gi...@apache.org>]

ferruzzi commented on code in PR #32356:
URL: https://github.com/apache/airflow/pull/32356#discussion_r1256730741


##########
airflow/providers/google/cloud/operators/dataflow.py:
##########
@@ -1015,11 +1016,11 @@ def on_kill(self) -> None:
 
 class DataflowCreatePythonJobOperator(GoogleCloudBaseOperator):
     """
-    Launching Cloud Dataflow jobs written in python. Note that both
-    dataflow_default_options and options will be merged to specify pipeline
-    execution parameter, and dataflow_default_options is expected to save
-    high-level options, for instances, project and zone information, which
-    apply to all dataflow operators in the DAG.
+    Launching Cloud Dataflow jobs written in python.
+
+     Note that both dataflow_default_options and options will be merged to specify pipeline
+    execution parameter, and dataflow_default_options is expected to save high-level options,
+    for instances, project and zone information, which apply to all dataflow operators in the DAG.
 
     This class is deprecated.
     Please use `providers.apache.beam.operators.beam.BeamRunPythonPipelineOperator`.

Review Comment:
   @uranusjr @potiuk  A number of these classed are deprecated.  Do we still want/need these complicated docstrings for them?  I'm guessing we do since the classes are still there and functional, huh?   That "This c;ass is deprecated" note is from [this commit](https://github.com/apache/airflow/pull/12814) back in 2021



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org