You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/06/21 03:42:52 UTC

[GitHub] [incubator-echarts-doc] plainheart commented on pull request #114: Add missing colon

plainheart commented on pull request #114:
URL: https://github.com/apache/incubator-echarts-doc/pull/114#issuecomment-647074656


   LGTM.
   But should we add a semicolon at the end of each line of property?
   Just like this
   ```js
   (dom: HTMLDivElement | HTMLCanvasElement, theme?: Object | string, opts?: {
       devicePixelRatio?: number;
       renderer?: string;
       width?: number | string;
       height?: number | string;
   }) => ECharts
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org