You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Yann Ylavic <yl...@gmail.com> on 2018/02/23 20:27:09 UTC
Re: svn commit: r1825169 - /httpd/httpd/trunk/modules/filters/config.m4
On Fri, Feb 23, 2018 at 9:23 PM, <wr...@apache.org> wrote:
> Author: wrowe
> Date: Fri Feb 23 20:23:10 2018
> New Revision: 1825169
>
> URL: http://svn.apache.org/viewvc?rev=1825169&view=rev
> Log:
> Propose backportable fix to accept libxml2 path in the
> base form or the absolute path to include tree form.
>
> Nowhere does the --with-libxml2= arg suggest the path
> is that of the include tree, and disagrees with httpd's
> use of --with- syntax for package location.
>
>
>
> Modified:
> httpd/httpd/trunk/modules/filters/config.m4
>
> Modified: httpd/httpd/trunk/modules/filters/config.m4
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/filters/config.m4?rev=1825169&r1=1825168&r2=1825169&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/filters/config.m4 (original)
> +++ httpd/httpd/trunk/modules/filters/config.m4 Fri Feb 23 20:23:10 2018
> @@ -100,7 +100,7 @@ AC_DEFUN([FIND_LIBXML2], [
> AC_CACHE_CHECK([for libxml2], [ac_cv_libxml2], [
> AC_ARG_WITH(libxml2,
> [APACHE_HELP_STRING(--with-libxml2=PATH,location for libxml2)],
> - [test_paths="${with_libxml2}"],
> + [test_paths="${with_libxml2}/include/libxml2 ${with_libxml2}/include ${with_libxml2}"],
+1, otherwise only "--with-libxml2=/usr/include/libxml2" works here
(there were users@ and/or bz reports IIRC too).
Thanks,
Yann.
Re: svn commit: r1825169 - /httpd/httpd/trunk/modules/filters/config.m4
Posted by William A Rowe Jr <wr...@rowe-clan.net>.
On Fri, Feb 23, 2018 at 2:27 PM, Yann Ylavic <yl...@gmail.com> wrote:
> On Fri, Feb 23, 2018 at 9:23 PM, <wr...@apache.org> wrote:
>> Author: wrowe
>> Date: Fri Feb 23 20:23:10 2018
>> New Revision: 1825169
>>
>> URL: http://svn.apache.org/viewvc?rev=1825169&view=rev
>> Log:
>> Propose backportable fix to accept libxml2 path in the
>> base form or the absolute path to include tree form.
>>
>> Nowhere does the --with-libxml2= arg suggest the path
>> is that of the include tree, and disagrees with httpd's
>> use of --with- syntax for package location.
>>
>>
>>
>> Modified:
>> httpd/httpd/trunk/modules/filters/config.m4
>>
>> Modified: httpd/httpd/trunk/modules/filters/config.m4
>> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/filters/config.m4?rev=1825169&r1=1825168&r2=1825169&view=diff
>> ==============================================================================
>> --- httpd/httpd/trunk/modules/filters/config.m4 (original)
>> +++ httpd/httpd/trunk/modules/filters/config.m4 Fri Feb 23 20:23:10 2018
>> @@ -100,7 +100,7 @@ AC_DEFUN([FIND_LIBXML2], [
>> AC_CACHE_CHECK([for libxml2], [ac_cv_libxml2], [
>> AC_ARG_WITH(libxml2,
>> [APACHE_HELP_STRING(--with-libxml2=PATH,location for libxml2)],
>> - [test_paths="${with_libxml2}"],
>> + [test_paths="${with_libxml2}/include/libxml2 ${with_libxml2}/include ${with_libxml2}"],
>
> +1, otherwise only "--with-libxml2=/usr/include/libxml2" works here
> (there were users@ and/or bz reports IIRC too).
This is half a fix, the config.m4 has never dealt with configuring
a proper -L flag value. And is challenging without knowing which
depth we are given. Will look at a 100% solution to trunk, the
bandaid seems sufficient this instant; if there are many httpd
dependencies in that libxml2 path, then another component
will likely resolve the -L flag for a typical user.