You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2017/10/22 17:27:58 UTC
Re: Review Request 63084: Fixed missing transformResources cases in
master::updateSlave.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63084/
-----------------------------------------------------------
(Updated Oct. 22, 2017, 5:27 p.m.)
Review request for mesos, Benjamin Bannier and Michael Park.
Changes
-------
Fix the `total_resources()` case too.
Summary (updated)
-----------------
Fixed missing transformResources cases in master::updateSlave.
Bugs: MESOS-8090
https://issues.apache.org/jira/browse/MESOS-8090
Repository: mesos
Description (updated)
-------
Fixed missing transformResources cases in master::updateSlave.
Diffs (updated)
-----
src/master/master.cpp 3603878f02ae3dba82811a4a5770dd21ec790ef6
Diff: https://reviews.apache.org/r/63084/diff/2/
Changes: https://reviews.apache.org/r/63084/diff/1-2/
Testing
-------
Connect a mesos agent from 1.3.1 build with oversubscription enabled to a master with this patch, and verifies that master can properly update over subscribed resources.
Without this patch master crashes like in MESOS-8090.
Thanks,
Zhitao Li
Re: Review Request 63084: Fixed missing transformResources cases in
master::updateSlave.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63084/#review188914
-----------------------------------------------------------
Patch looks great!
Reviews applied: [63084]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 22, 2017, 5:27 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63084/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2017, 5:27 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Michael Park.
>
>
> Bugs: MESOS-8090
> https://issues.apache.org/jira/browse/MESOS-8090
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed missing transformResources cases in master::updateSlave.
>
>
> Diffs
> -----
>
> src/master/master.cpp 3603878f02ae3dba82811a4a5770dd21ec790ef6
>
>
> Diff: https://reviews.apache.org/r/63084/diff/2/
>
>
> Testing
> -------
>
> Connect a mesos agent from 1.3.1 build with oversubscription enabled to a master with this patch, and verifies that master can properly update over subscribed resources.
>
> Without this patch master crashes like in MESOS-8090.
>
>
> Thanks,
>
> Zhitao Li
>
>