[GitHub] [kafka] C0urante commented on pull request #12321: KAFKA-14012: Adding null checks for cases when closeQuietly was being passed a lambda object

[GitBox <gi...@apache.org>]

C0urante commented on PR #12321:
URL: https://github.com/apache/kafka/pull/12321#issuecomment-1164991017

   > Do you think we can have a follow up ticket for this?
   
   Yes, this can definitely be a follow-up. Although given how small this PR has become, it'd be fine to add on here as well.
   
   FWIW, the more I think about it the more appealing option 1 seems. The variant I proposed for `Utils::closeQuietly` is a little inelegant, and doesn't do anything to actually prevent people from falling into this same trap in the future. It's cleaner and, AFAICT, just as safe to switch things over to implementing `AutoCloseable`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org