[GitHub] [arrow] MarcoGorelli commented on a change in pull request #9045: ARROW-11180: [CI] cmake-format pre-commit hook doesn't run

[GitBox <gi...@apache.org>]

MarcoGorelli commented on a change in pull request #9045:
URL: https://github.com/apache/arrow/pull/9045#discussion_r553795616



##########
File path: .pre-commit-config.yaml
##########
@@ -40,9 +40,10 @@ repos:
       - id: cmake-format
         name: CMake Format
         language: python
-        entry: bash -c "pip install cmake-format && python run-cmake-format.py --check"
-        entry: echo
-        files: ^(.*/CMakeLists.txt|.*.cmake)$
+        entry: cmake-format --in-place --autosort=false

Review comment:
       you could use `pass_filenames: false` in pre-commit so that it'll just run `python run-cmake-format.py`, like this configuration will all be there
   
   > It seems that pre-commit runs cmake-format for each target file.
   
   I don't think so, it should just run `cmake-format file1 file2 ... filen`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org