You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuweni.apache.org by GitBox <gi...@apache.org> on 2020/12/09 08:33:11 UTC
[GitHub] [incubator-tuweni] atoulme opened a new pull request #182: JSON-RPC/Wallet
atoulme opened a new pull request #182:
URL: https://github.com/apache/incubator-tuweni/pull/182
<!-- Thanks for sending a pull request! Please check out our contribution guidelines: -->
<!-- https://github.com/apache/incubator-tuweni/blob/master/CONTRIBUTING.md -->
## PR description
Add fundamentals of a faucet: a wallet and a JSON-RPC client
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] commented on pull request #182: JSON-RPC/Wallet
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #182:
URL: https://github.com/apache/incubator-tuweni/pull/182#issuecomment-743926001
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/182?src=pr&el=h1) Report
> Merging [#182](https://codecov.io/gh/apache/incubator-tuweni/pull/182?src=pr&el=desc) (2225623) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/db38b1aff0217d4e19a47491bdd8cebb2eb9611c?el=desc) (db38b1a) will **decrease** coverage by `13.09%`.
> The diff coverage is `44.31%`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/182?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #182 +/- ##
=============================================
- Coverage 61.16% 48.07% -13.10%
+ Complexity 3887 606 -3281
=============================================
Files 352 128 -224
Lines 19899 5905 -13994
Branches 2505 677 -1828
=============================================
- Hits 12172 2839 -9333
+ Misses 6437 2789 -3648
+ Partials 1290 277 -1013
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `48.07% <44.31%> (?)` | `0.00 <3.00> (?)` | |
| unit | `?` | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/182?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../kotlin/org/apache/tuweni/devp2p/eth/EthHandler.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIYW5kbGVyLmt0) | `0.00% <0.00%> (-25.65%)` | `0.00 <0.00> (-7.00)` | |
| [...lin/org/apache/tuweni/devp2p/eth/EthSubprotocol.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhTdWJwcm90b2NvbC5rdA==) | `0.00% <0.00%> (-77.78%)` | `0.00 <0.00> (-12.00)` | |
| [...in/kotlin/org/apache/tuweni/devp2p/eth/Messages.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9NZXNzYWdlcy5rdA==) | `0.00% <0.00%> (-94.45%)` | `0.00 <0.00> (ø)` | |
| [...src/main/kotlin/org/apache/tuweni/devp2p/Packet.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGFja2V0Lmt0) | `0.00% <0.00%> (-79.75%)` | `0.00 <0.00> (-6.00)` | |
| [...p/src/main/kotlin/org/apache/tuweni/devp2p/Peer.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlci5rdA==) | `0.00% <0.00%> (-33.34%)` | `0.00 <0.00> (ø)` | |
| [.../kotlin/org/apache/tuweni/devp2p/PeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlclJlcG9zaXRvcnkua3Q=) | `20.00% <0.00%> (-52.50%)` | `0.00 <0.00> (ø)` | |
| [...rc/main/kotlin/org/apache/tuweni/devp2p/Scraper.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvU2NyYXBlci5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...kotlin/org/apache/tuweni/devp2p/v5/RoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvUm91dGluZ1RhYmxlLmt0) | `36.36% <ø> (-40.91%)` | `1.00 <0.00> (-7.00)` | |
| [...main/kotlin/org/apache/tuweni/devp2p/v5/Scraper.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2NyYXBlci5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...main/kotlin/org/apache/tuweni/devp2p/v5/Session.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2Vzc2lvbi5rdA==) | `4.76% <0.00%> (+4.76%)` | `3.00 <0.00> (+3.00)` | |
| ... and [346 more](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/182?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/182?src=pr&el=footer). Last update [db38b1a...2225623](https://codecov.io/gh/apache/incubator-tuweni/pull/182?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #182: JSON-RPC/Wallet
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #182:
URL: https://github.com/apache/incubator-tuweni/pull/182#issuecomment-743926001
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/182?src=pr&el=h1) Report
> Merging [#182](https://codecov.io/gh/apache/incubator-tuweni/pull/182?src=pr&el=desc) (2225623) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/db38b1aff0217d4e19a47491bdd8cebb2eb9611c?el=desc) (db38b1a) will **decrease** coverage by `13.09%`.
> The diff coverage is `44.31%`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/182?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #182 +/- ##
=============================================
- Coverage 61.16% 48.07% -13.10%
+ Complexity 3887 606 -3281
=============================================
Files 352 128 -224
Lines 19899 5905 -13994
Branches 2505 677 -1828
=============================================
- Hits 12172 2839 -9333
+ Misses 6437 2789 -3648
+ Partials 1290 277 -1013
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `48.07% <44.31%> (?)` | `0.00 <3.00> (?)` | |
| unit | `?` | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/182?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../kotlin/org/apache/tuweni/devp2p/eth/EthHandler.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIYW5kbGVyLmt0) | `0.00% <0.00%> (-25.65%)` | `0.00 <0.00> (-7.00)` | |
| [...lin/org/apache/tuweni/devp2p/eth/EthSubprotocol.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhTdWJwcm90b2NvbC5rdA==) | `0.00% <0.00%> (-77.78%)` | `0.00 <0.00> (-12.00)` | |
| [...in/kotlin/org/apache/tuweni/devp2p/eth/Messages.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9NZXNzYWdlcy5rdA==) | `0.00% <0.00%> (-94.45%)` | `0.00 <0.00> (ø)` | |
| [...src/main/kotlin/org/apache/tuweni/devp2p/Packet.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGFja2V0Lmt0) | `0.00% <0.00%> (-79.75%)` | `0.00 <0.00> (-6.00)` | |
| [...p/src/main/kotlin/org/apache/tuweni/devp2p/Peer.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlci5rdA==) | `0.00% <0.00%> (-33.34%)` | `0.00 <0.00> (ø)` | |
| [.../kotlin/org/apache/tuweni/devp2p/PeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlclJlcG9zaXRvcnkua3Q=) | `20.00% <0.00%> (-52.50%)` | `0.00 <0.00> (ø)` | |
| [...rc/main/kotlin/org/apache/tuweni/devp2p/Scraper.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvU2NyYXBlci5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...kotlin/org/apache/tuweni/devp2p/v5/RoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvUm91dGluZ1RhYmxlLmt0) | `36.36% <ø> (-40.91%)` | `1.00 <0.00> (-7.00)` | |
| [...main/kotlin/org/apache/tuweni/devp2p/v5/Scraper.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2NyYXBlci5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...main/kotlin/org/apache/tuweni/devp2p/v5/Session.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2Vzc2lvbi5rdA==) | `4.76% <0.00%> (+4.76%)` | `3.00 <0.00> (+3.00)` | |
| ... and [346 more](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/182?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/182?src=pr&el=footer). Last update [db38b1a...395fe2e](https://codecov.io/gh/apache/incubator-tuweni/pull/182?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] atoulme merged pull request #182: JSON-RPC/Wallet
Posted by GitBox <gi...@apache.org>.
atoulme merged pull request #182:
URL: https://github.com/apache/incubator-tuweni/pull/182
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #182: JSON-RPC/Wallet
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #182:
URL: https://github.com/apache/incubator-tuweni/pull/182#issuecomment-743926001
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/182?src=pr&el=h1) Report
> Merging [#182](https://codecov.io/gh/apache/incubator-tuweni/pull/182?src=pr&el=desc) (395fe2e) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/db38b1aff0217d4e19a47491bdd8cebb2eb9611c?el=desc) (db38b1a) will **decrease** coverage by `0.15%`.
> The diff coverage is `55.83%`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/182?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #182 +/- ##
============================================
- Coverage 61.16% 61.01% -0.16%
- Complexity 3887 3889 +2
============================================
Files 352 347 -5
Lines 19899 19572 -327
Branches 2505 2592 +87
============================================
- Hits 12172 11942 -230
+ Misses 6437 6288 -149
- Partials 1290 1342 +52
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| unit | `61.01% <55.83%> (-0.16%)` | `0.00 <30.00> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/182?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/apache/tuweni/concurrent/coroutines/Retryable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-Y29uY3VycmVudC1jb3JvdXRpbmVzL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9jb25jdXJyZW50L2Nvcm91dGluZXMvUmV0cnlhYmxlLmt0) | `61.36% <ø> (-3.86%)` | `0.00 <0.00> (ø)` | |
| [...ava/org/apache/tuweni/crypto/sodium/SecretBox.java](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-Y3J5cHRvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY3J5cHRvL3NvZGl1bS9TZWNyZXRCb3guamF2YQ==) | `29.78% <0.00%> (+0.07%)` | `16.00 <1.00> (ø)` | |
| [.../kotlin/org/apache/tuweni/devp2p/eth/EthHandler.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIYW5kbGVyLmt0) | `21.92% <0.00%> (-3.72%)` | `7.00 <0.00> (ø)` | |
| [...p/src/main/kotlin/org/apache/tuweni/devp2p/Peer.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlci5rdA==) | `33.33% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../kotlin/org/apache/tuweni/devp2p/PeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlclJlcG9zaXRvcnkua3Q=) | `72.50% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...rc/main/kotlin/org/apache/tuweni/devp2p/Scraper.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvU2NyYXBlci5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...kotlin/org/apache/tuweni/devp2p/v5/RoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvUm91dGluZ1RhYmxlLmt0) | `77.27% <ø> (ø)` | `8.00 <0.00> (ø)` | |
| [...main/kotlin/org/apache/tuweni/devp2p/v5/Scraper.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2NyYXBlci5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...main/kotlin/org/apache/tuweni/devp2p/v5/Session.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2Vzc2lvbi5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...tlin/org/apache/tuweni/ethclient/EthereumClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZXRoLWNsaWVudC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50L0V0aGVyZXVtQ2xpZW50Lmt0) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [90 more](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/182?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/182?src=pr&el=footer). Last update [db38b1a...395fe2e](https://codecov.io/gh/apache/incubator-tuweni/pull/182?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #182: JSON-RPC/Wallet
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #182:
URL: https://github.com/apache/incubator-tuweni/pull/182#issuecomment-743926001
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/182?src=pr&el=h1) Report
> Merging [#182](https://codecov.io/gh/apache/incubator-tuweni/pull/182?src=pr&el=desc) (395fe2e) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/db38b1aff0217d4e19a47491bdd8cebb2eb9611c?el=desc) (db38b1a) will **increase** coverage by `4.56%`.
> The diff coverage is `68.63%`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/182?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #182 +/- ##
============================================
+ Coverage 61.16% 65.73% +4.56%
- Complexity 3887 4185 +298
============================================
Files 352 372 +20
Lines 19899 19953 +54
Branches 2505 2599 +94
============================================
+ Hits 12172 13116 +944
+ Misses 6437 5379 -1058
- Partials 1290 1458 +168
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `48.06% <44.31%> (?)` | `0.00 <18.00> (?)` | |
| unit | `61.01% <55.83%> (-0.16%)` | `0.00 <31.00> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/182?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/apache/tuweni/concurrent/coroutines/Retryable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-Y29uY3VycmVudC1jb3JvdXRpbmVzL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9jb25jdXJyZW50L2Nvcm91dGluZXMvUmV0cnlhYmxlLmt0) | `61.36% <ø> (-3.86%)` | `0.00 <0.00> (ø)` | |
| [...ava/org/apache/tuweni/crypto/sodium/SecretBox.java](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-Y3J5cHRvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY3J5cHRvL3NvZGl1bS9TZWNyZXRCb3guamF2YQ==) | `29.78% <0.00%> (+0.07%)` | `16.00 <1.00> (ø)` | |
| [.../kotlin/org/apache/tuweni/devp2p/eth/EthHandler.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIYW5kbGVyLmt0) | `21.92% <0.00%> (-3.72%)` | `7.00 <0.00> (ø)` | |
| [...p/src/main/kotlin/org/apache/tuweni/devp2p/Peer.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlci5rdA==) | `33.33% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../kotlin/org/apache/tuweni/devp2p/PeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlclJlcG9zaXRvcnkua3Q=) | `72.50% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...rc/main/kotlin/org/apache/tuweni/devp2p/Scraper.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvU2NyYXBlci5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...kotlin/org/apache/tuweni/devp2p/v5/RoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvUm91dGluZ1RhYmxlLmt0) | `77.27% <ø> (ø)` | `8.00 <0.00> (ø)` | |
| [...main/kotlin/org/apache/tuweni/devp2p/v5/Scraper.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2NyYXBlci5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...main/kotlin/org/apache/tuweni/devp2p/v5/Session.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2Vzc2lvbi5rdA==) | `4.76% <0.00%> (+4.76%)` | `3.00 <0.00> (+3.00)` | |
| [...in/org/apache/tuweni/les/GetBlockHeadersMessage.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree#diff-bGVzL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9sZXMvR2V0QmxvY2tIZWFkZXJzTWVzc2FnZS5rdA==) | `100.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| ... and [154 more](https://codecov.io/gh/apache/incubator-tuweni/pull/182/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/182?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/182?src=pr&el=footer). Last update [db38b1a...395fe2e](https://codecov.io/gh/apache/incubator-tuweni/pull/182?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org