[ACS4.4] cherry-pick policy (was: Cherry-pick d5425e1a4a8ed4cadc2f9b97f82f6f608e9a51de)

[Daan Hoogland <da...@gmail.com>]

anybody else got comments? I feel I am on the edge of solid ground and
slippery slope. Nitin's argument is good as (almost) good as mine.

On Mon, May 19, 2014 at 11:05 PM, Nitin Mehta <Ni...@citrix.com> wrote:
> Sure I understand. Its fine by me. But, its not a new feature. Its adding
> a param to the api so a minor enhancement.
>
> Thanks,
> -Nitin
>
> On 19/05/14 1:47 PM, "Daan Hoogland" <da...@gmail.com> wrote:
>
>>even so Nitin, it is a new feature with no unit or integration tests.
>>I feel I would be neglecting my task as release manager if I let this
>>in.
>>
>>sorry,
>>Daan
>>
>>On Mon, May 19, 2014 at 7:46 PM, Nitin Mehta <Ni...@citrix.com>
>>wrote:
>>> Sure Daan. The current listResouceDetails api lists the metadata for all
>>> the first class entities and currently doesn't have the flexibility to
>>> list it by key,value pair which I think is a basic must have. That¹s
>>>why I
>>> propose it to be included in 4.4.
>>>
>>> Thanks,
>>> -Nitin
>>>
>>> On 19/05/14 2:10 AM, "Daan Hoogland" <da...@gmail.com> wrote:
>>>
>>>>Nitin,
>>>>
>>>>This seems like an enhancement to me. Is there anything broken that is
>>>>fixed by this enhancement?
>>>>Please spend some lines to justify why it should be in 4.4?
>>>>
>>>>thanks,
>>>>Daan
>>>>
>>>>On Mon, May 19, 2014 at 8:50 AM, Nitin Mehta <Ni...@citrix.com>
>>>>wrote:
>>>>> Hi Daan,
>>>>> Can you please cherry-pick the following commit
>>>>> d5425e1a4a8ed4cadc2f9b97f82f6f608e9a51de in 4.4 for CLOUDSTACK-6699 ?
>>>>>
>>>>> Thanks,
>>>>> -Nitin
>>>>
>>>>
>>>>
>>>>--
>>>>Daan
>>>
>>
>>
>>
>>--
>>Daan
>



-- 
Daan

RE: [ACS4.4] cherry-pick policy (was: Cherry-pick d5425e1a4a8ed4cadc2f9b97f82f6f608e9a51de)

[Alex Hitchins <al...@alexhitchins.com>]

To me this looks like an enhancement rather than a feature, however I'd be happy to say that enhancements are worthy of specifications/unit tests.

I'm working on a few small enhancements now and have written up a spec for each. I think it helps focus the mind on the task and enables people to trace back over time.

Just my £0.02 (€0.0246082)


Alex Hitchins | 07788 423 969 | 01892 523 587

-----Original Message-----
From: Daan Hoogland [mailto:daan.hoogland@gmail.com] 
Sent: 19 May 2014 22:57
To: dev
Subject: [ACS4.4] cherry-pick policy (was: Cherry-pick d5425e1a4a8ed4cadc2f9b97f82f6f608e9a51de)

anybody else got comments? I feel I am on the edge of solid ground and slippery slope. Nitin's argument is good as (almost) good as mine.

On Mon, May 19, 2014 at 11:05 PM, Nitin Mehta <Ni...@citrix.com> wrote:
> Sure I understand. Its fine by me. But, its not a new feature. Its 
> adding a param to the api so a minor enhancement.
>
> Thanks,
> -Nitin
>
> On 19/05/14 1:47 PM, "Daan Hoogland" <da...@gmail.com> wrote:
>
>>even so Nitin, it is a new feature with no unit or integration tests.
>>I feel I would be neglecting my task as release manager if I let this 
>>in.
>>
>>sorry,
>>Daan
>>
>>On Mon, May 19, 2014 at 7:46 PM, Nitin Mehta <Ni...@citrix.com>
>>wrote:
>>> Sure Daan. The current listResouceDetails api lists the metadata for 
>>>all  the first class entities and currently doesn't have the 
>>>flexibility to  list it by key,value pair which I think is a basic 
>>>must have. That¹s why I  propose it to be included in 4.4.
>>>
>>> Thanks,
>>> -Nitin
>>>
>>> On 19/05/14 2:10 AM, "Daan Hoogland" <da...@gmail.com> wrote:
>>>
>>>>Nitin,
>>>>
>>>>This seems like an enhancement to me. Is there anything broken that 
>>>>is fixed by this enhancement?
>>>>Please spend some lines to justify why it should be in 4.4?
>>>>
>>>>thanks,
>>>>Daan
>>>>
>>>>On Mon, May 19, 2014 at 8:50 AM, Nitin Mehta 
>>>><Ni...@citrix.com>
>>>>wrote:
>>>>> Hi Daan,
>>>>> Can you please cherry-pick the following commit 
>>>>> d5425e1a4a8ed4cadc2f9b97f82f6f608e9a51de in 4.4 for CLOUDSTACK-6699 ?
>>>>>
>>>>> Thanks,
>>>>> -Nitin
>>>>
>>>>
>>>>
>>>>--
>>>>Daan
>>>
>>
>>
>>
>>--
>>Daan
>



--
Daan