You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Joe Knudsen (JIRA)" <de...@myfaces.apache.org> on 2009/02/19 21:54:01 UTC
[jira] Created: (TOMAHAWK-1395) selectManyCheckbox does not render
space between checkbox and label on Firefox
selectManyCheckbox does not render space between checkbox and label on Firefox
------------------------------------------------------------------------------
Key: TOMAHAWK-1395
URL: https://issues.apache.org/jira/browse/TOMAHAWK-1395
Project: MyFaces Tomahawk
Issue Type: Bug
Affects Versions: 1.1.9-SNAPSHOT
Environment: I am using Windows XP, Firefox 3.0.6 with Tomcat 6.0.18 and MyFaces 1.2.5
Reporter: Joe Knudsen
Priority: Minor
The checkbox is rendered without a space before the label using Firefox. Testing with h:selectManyCheckbox and that looked good.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-1395) selectManyCheckbox does not
render space between checkbox and label on Firefox
Posted by "Joe Knudsen (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706443#action_12706443 ]
Joe Knudsen commented on TOMAHAWK-1395:
---------------------------------------
Come on. The tomahawk widget should produce the same look as the JSF widget. I switched to using h:selectManyCheckbox where I do not have two columns and they look great. I tried using CSS after a day of effort I cannot get that to work. I am far from a CSS expert. It seems like a simple fix. I have added it to my code and I am using the tomahawk12-1-1.x but I cannot get the tests to pass so the build fails.
> selectManyCheckbox does not render space between checkbox and label on Firefox
> ------------------------------------------------------------------------------
>
> Key: TOMAHAWK-1395
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1395
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Affects Versions: 1.1.9-SNAPSHOT
> Environment: I am using Windows XP, Firefox 3.0.6 with Tomcat 6.0.18 and MyFaces 1.2.5
> Reporter: Joe Knudsen
> Priority: Minor
> Attachments: Firefox render selectManyCheckbox without space.jpg
>
>
> The checkbox is rendered without a space before the label using Firefox. Testing with h:selectManyCheckbox and that looked good.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TOMAHAWK-1395) selectManyCheckbox does not render
space between checkbox and label on Firefox
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leonardo Uribe resolved TOMAHAWK-1395.
--------------------------------------
Resolution: Fixed
Fix Version/s: 1.1.9-SNAPSHOT
Assignee: Leonardo Uribe
After another checking, there was a missing
writer.write(HTML.NBSP_ENTITY);
before the label on the class org.apache.myfaces.renderkit.html.ext.HtmlCheckboxRenderer (file on tomahawk core12). The renderer on tomahawk core is fine. Thanks for the attention in the details.
> selectManyCheckbox does not render space between checkbox and label on Firefox
> ------------------------------------------------------------------------------
>
> Key: TOMAHAWK-1395
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1395
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Affects Versions: 1.1.9-SNAPSHOT
> Environment: I am using Windows XP, Firefox 3.0.6 with Tomcat 6.0.18 and MyFaces 1.2.5
> Reporter: Joe Knudsen
> Assignee: Leonardo Uribe
> Priority: Minor
> Fix For: 1.1.9-SNAPSHOT
>
> Attachments: Firefox render selectManyCheckbox without space.jpg
>
>
> The checkbox is rendered without a space before the label using Firefox. Testing with h:selectManyCheckbox and that looked good.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-1395) selectManyCheckbox does not
render space between checkbox and label on Firefox
Posted by "Joe Knudsen (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681516#action_12681516 ]
Joe Knudsen commented on TOMAHAWK-1395:
---------------------------------------
Here is the HTML. It looks like just a space in needed. I may try to make the fix myself.
<table class="DynamicContent" id="frmSearchDiscrepancies:chkAssessmentDiscrepancies"><tr><td><label><input id="frmSearchDiscrepancies:chkAssessmentDiscrepancies:0" type="checkbox" name="frmSearchDiscrepancies:chkAssessmentDiscrepancies" checked="checked" value="3" />2008 Assessment data with errors.</label></td></tr><tr><td><label><input id="frmSearchDiscrepancies:chkAssessmentDiscrepancies:0" type="checkbox" name="frmSearchDiscrepancies:chkAssessmentDiscrepancies" checked="checked" value="4" />2008 Assessment data inconsistent with 2008 MARSS enrollment data.</label></td></tr><tr><td><label><input id="frmSearchDiscrepancies:chkAssessmentDiscrepancies:0" type="checkbox" name="frmSearchDiscrepancies:chkAssessmentDiscrepancies" value="5" />2008 Assessments not matched with 2008 MARSS enrollments.</label></td></tr><tr><td><label><input id="frmSearchDiscrepancies:chkAssessmentDiscrepancies:0" type="checkbox" name="frmSearchDiscrepancies:chkAssessmentDiscrepancies" value="6" />2008 Assessments only matched with 2008 MARSS enrollments outside my district.</label></td></tr><tr><td><label><input id="frmSearchDiscrepancies:chkAssessmentDiscrepancies:0" type="checkbox" name="frmSearchDiscrepancies:chkAssessmentDiscrepancies" value="7" />2008 Assessments without two years prior valid scores.</label></td></tr></table>
> selectManyCheckbox does not render space between checkbox and label on Firefox
> ------------------------------------------------------------------------------
>
> Key: TOMAHAWK-1395
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1395
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Affects Versions: 1.1.9-SNAPSHOT
> Environment: I am using Windows XP, Firefox 3.0.6 with Tomcat 6.0.18 and MyFaces 1.2.5
> Reporter: Joe Knudsen
> Priority: Minor
> Attachments: Firefox render selectManyCheckbox without space.jpg
>
>
> The checkbox is rendered without a space before the label using Firefox. Testing with h:selectManyCheckbox and that looked good.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-1395) selectManyCheckbox does not
render space between checkbox and label on Firefox
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681563#action_12681563 ]
Leonardo Uribe commented on TOMAHAWK-1395:
------------------------------------------
It seems a simple css style can do it, but I don't believe we can do something. It seems you are using tomahawk-1.1.x. Does this happens in tomahawk12-1.1.x too?
> selectManyCheckbox does not render space between checkbox and label on Firefox
> ------------------------------------------------------------------------------
>
> Key: TOMAHAWK-1395
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1395
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Affects Versions: 1.1.9-SNAPSHOT
> Environment: I am using Windows XP, Firefox 3.0.6 with Tomcat 6.0.18 and MyFaces 1.2.5
> Reporter: Joe Knudsen
> Priority: Minor
> Attachments: Firefox render selectManyCheckbox without space.jpg
>
>
> The checkbox is rendered without a space before the label using Firefox. Testing with h:selectManyCheckbox and that looked good.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-1395) selectManyCheckbox does not
render space between checkbox and label on Firefox
Posted by "Joe Knudsen (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675129#action_12675129 ]
Joe Knudsen commented on TOMAHAWK-1395:
---------------------------------------
Should have said above. Using Firefox no space exists between the checkbox and the label. Looks fine on IE 7. Also tested h:selectManyCheckbox and that looks good on both.
> selectManyCheckbox does not render space between checkbox and label on Firefox
> ------------------------------------------------------------------------------
>
> Key: TOMAHAWK-1395
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1395
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Affects Versions: 1.1.9-SNAPSHOT
> Environment: I am using Windows XP, Firefox 3.0.6 with Tomcat 6.0.18 and MyFaces 1.2.5
> Reporter: Joe Knudsen
> Priority: Minor
> Attachments: Firefox render selectManyCheckbox without space.jpg
>
>
> The checkbox is rendered without a space before the label using Firefox. Testing with h:selectManyCheckbox and that looked good.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.