You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "dependabot[bot] (via GitHub)" <gi...@apache.org> on 2023/06/21 09:08:31 UTC
[GitHub] [arrow] dependabot[bot] opened a new pull request, #36195: MINOR: [CI]: Bump actions/setup-go from 3 to 4
dependabot[bot] opened a new pull request, #36195:
URL: https://github.com/apache/arrow/pull/36195
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 3 to 4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/setup-go/releases">actions/setup-go's releases</a>.</em></p>
<blockquote>
<h2>v4.0.0</h2>
<p>In scope of release we enable cache by default. The action won’t throw an error if the cache can’t be restored or saved. The action will throw a warning message but it won’t stop a build process. The cache can be disabled by specifying <code>cache: false</code>.</p>
<pre lang="yaml"><code>steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v4
with:
go-version: ‘1.19’
- run: go run hello.go
</code></pre>
<p>Besides, we introduce such changes as</p>
<ul>
<li><a href="https://redirect.github.com/actions/setup-go/pull/305">Allow to use only GOCACHE for cache</a></li>
<li><a href="https://redirect.github.com/actions/setup-go/pull/315">Bump json5 from 2.2.1 to 2.2.3</a></li>
<li><a href="https://redirect.github.com/actions/setup-go/pull/323">Use proper version for primary key in cache</a></li>
<li><a href="https://redirect.github.com/actions/setup-go/pull/351">Always add Go bin to the PATH</a></li>
<li><a href="https://redirect.github.com/actions/setup-go/pull/350">Add step warning if go-version input is empty</a></li>
</ul>
<h2>Add support for stable and oldstable aliases</h2>
<p>In scope of this release we introduce aliases for the <code>go-version</code> input. The <code>stable</code> alias instals the latest stable version of Go. The <code>oldstable</code> alias installs previous latest minor release (the stable is 1.19.x -> the oldstable is 1.18.x).</p>
<h3>Stable</h3>
<pre lang="yaml"><code>steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
with:
go-version: 'stable'
- run: go run hello.go
</code></pre>
<h3>OldStable</h3>
<pre lang="yaml"><code>steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
with:
go-version: 'oldstable'
- run: go run hello.go
</code></pre>
<h2>Add support for go.work and pass the token input through on GHES</h2>
<p>In scope of this release we added <a href="https://redirect.github.com/actions/setup-go/pull/283">support for go.work file to pass it in go-version-file input</a>.</p>
<pre lang="yaml"><code>steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
</tr></table>
</code></pre>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/setup-go/commit/fac708d6674e30b6ba41289acaab6d4b75aa0753"><code>fac708d</code></a> Bump <code>@actions/cache</code> dependency to v3.2.1 (<a href="https://redirect.github.com/actions/setup-go/issues/374">#374</a>)</li>
<li><a href="https://github.com/actions/setup-go/commit/dd84a9531a6f8e72c321f2aa3b9048ed359670e4"><code>dd84a95</code></a> Update xml2js (<a href="https://redirect.github.com/actions/setup-go/issues/370">#370</a>)</li>
<li><a href="https://github.com/actions/setup-go/commit/41c2024c46acfe1d0b8c9b7f20e28406983e553b"><code>41c2024</code></a> Fix glob bug in package.json scripts section (<a href="https://redirect.github.com/actions/setup-go/issues/359">#359</a>)</li>
<li><a href="https://github.com/actions/setup-go/commit/8dbf352f069be09d9a0b567cc1a9d16a5663fc3a"><code>8dbf352</code></a> update README fo v4 (<a href="https://redirect.github.com/actions/setup-go/issues/354">#354</a>)</li>
<li><a href="https://github.com/actions/setup-go/commit/4d34df0c2316fe8122ab82dc22947d607c0c91f9"><code>4d34df0</code></a> Update configuration files (<a href="https://redirect.github.com/actions/setup-go/issues/348">#348</a>)</li>
<li><a href="https://github.com/actions/setup-go/commit/fdc0d672a12b8fc05ef4c549c3fd5b0f03ebeb4c"><code>fdc0d67</code></a> Add Go bin if go-version input is empty (<a href="https://redirect.github.com/actions/setup-go/issues/351">#351</a>)</li>
<li><a href="https://github.com/actions/setup-go/commit/ebfdf6ac95bce0e7e743a60aba7adf59b400885b"><code>ebfdf6a</code></a> add warning if go-version is empty (<a href="https://redirect.github.com/actions/setup-go/issues/350">#350</a>)</li>
<li><a href="https://github.com/actions/setup-go/commit/b27d76912e7cb72b7262b5be2ec903b6cfaf358a"><code>b27d769</code></a> fix lockfileVersion (<a href="https://redirect.github.com/actions/setup-go/issues/349">#349</a>)</li>
<li><a href="https://github.com/actions/setup-go/commit/c51a7207680f1bee06f4a751214aab70667f9e25"><code>c51a720</code></a> Enable caching by default with default input (<a href="https://redirect.github.com/actions/setup-go/issues/332">#332</a>)</li>
<li><a href="https://github.com/actions/setup-go/commit/6b848af622919e18822928df24a57044dc6ea9ab"><code>6b848af</code></a> Merge pull request <a href="https://redirect.github.com/actions/setup-go/issues/343">#343</a> from akv-platform/reusable-workflow</li>
<li>Additional commits viewable in <a href="https://github.com/actions/setup-go/compare/v3...v4">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #36195: MINOR: [CI] Bump actions/setup-go from 3 to 4
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #36195:
URL: https://github.com/apache/arrow/pull/36195#issuecomment-1601899338
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jgehrcke commented on pull request #36195: MINOR: [CI]: Bump actions/setup-go from 3 to 4
Posted by "jgehrcke (via GitHub)" <gi...@apache.org>.
jgehrcke commented on PR #36195:
URL: https://github.com/apache/arrow/pull/36195#issuecomment-1600599390
> Is there any reason we are raising an AssertionError here?
Yes, this code is not supposed to execute in GHA for a non-main branch:
https://github.com/apache/arrow/blob/e6221c45de7b4c675bcedfac9afb87f6a131dad9/ci/scripts/go_bench_adapt.py#L50
```
else:
# Assume that the environment is not GitHub Actions CI. Error out if that
# assumption seems to be wrong.
assert os.getenv("GITHUB_ACTIONS") is None
# This is probably a local dev environment, for testing. In this case, it
# does usually not make sense to provide commit information (not a
# controlled CI environment). Explicitly keep `github_commit_info=None` to
# reflect that (to not send commit information).
```
In that sense I think the failure is expected and does / should not block merge. If the redness is a problem then we can also sys.exit(0) instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #36195: MINOR: [CI]: Bump actions/setup-go from 3 to 4
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #36195:
URL: https://github.com/apache/arrow/pull/36195#issuecomment-1600529622
Some of the failures are related to the benchmark tests here:
```
Traceback (most recent call last):
File "/Users/runner/work/arrow/arrow/ci/scripts/go_bench_adapt.py", line 52, in <module>
assert os.getenv("GITHUB_ACTIONS") is None
AssertionError
```
Is there any reason we are raising an `AssertionError` here?
@zeroshade @jgehrcke
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #36195: MINOR: [CI] Bump actions/setup-go from 3 to 4
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #36195:
URL: https://github.com/apache/arrow/pull/36195#issuecomment-1601608587
I've opened a new issue for it: #36218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #36195: MINOR: [CI] Bump actions/setup-go from 3 to 4
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #36195:
URL: https://github.com/apache/arrow/pull/36195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #36195: MINOR: [CI]: Bump actions/setup-go from 3 to 4
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #36195:
URL: https://github.com/apache/arrow/pull/36195#issuecomment-1600624989
Ok, I think the problem is that the PR from dependabot is coming from a branch on the apache/arrow repository instead of a fork hence those are executed which are not if they are from a fork branch due to:
`if: success() && github.event_name == 'push' && github.repository == 'apache/arrow'`
Probably we should not error and just do a `sys.exit(0)` but now I understand why this is failing here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36195: MINOR: [CI] Bump actions/setup-go from 3 to 4
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36195:
URL: https://github.com/apache/arrow/pull/36195#issuecomment-1605764442
Conbench analyzed the 6 benchmark runs on commit `320ecbd1`.
There were 5 benchmark results indicating a performance regression:
- Commit Run on `ursa-i9-9960x` at [2023-06-24 20:10:19Z](http://conbench.ursa.dev/compare/runs/e220c510ac5141a484480569fb74203d...42c7a54ea8cb412595f54306888a5e9a/)
- [compression=uncompressed, dataset=fanniemae_2016Q4, file_type=feather, language=R, output_type=table](http://conbench.ursa.dev/compare/benchmarks/06497354012277488000a119afb7b061...06497614cbe97fc38000a7abd34ac1e2)
- [compression=uncompressed, dataset=fanniemae_2016Q4, file_type=feather, language=R, output_type=dataframe](http://conbench.ursa.dev/compare/benchmarks/06497354b80e762e8000fb36a060e557...06497615e81e7ec3800083d5d64c3ca5)
- and 3 more (see the report linked below)
The [full Conbench report](https://github.com/apache/arrow/runs/14527439644) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org