[GitHub] [iotdb] JackieTien97 commented on a change in pull request #4303: [IOTDB-1760] Support other aggregations in group by fill

[GitBox <gi...@apache.org>]

JackieTien97 commented on a change in pull request #4303:
URL: https://github.com/apache/iotdb/pull/4303#discussion_r741831872



##########
File path: server/src/main/java/org/apache/iotdb/db/query/dataset/groupby/GroupByWithoutValueFilterDataSet.java
##########
@@ -51,10 +51,10 @@
 
 public class GroupByWithoutValueFilterDataSet extends GroupByEngineDataSet {
 
-  private static final Logger logger =
+  protected static final Logger logger =

Review comment:
       You should construct a new Logger using the Subclass in itself.

##########
File path: server/src/main/java/org/apache/iotdb/db/query/executor/QueryRouter.java
##########
@@ -252,15 +256,28 @@ protected FillQueryExecutor getFillExecutor(FillQueryPlan plan) {
   public QueryDataSet groupByFill(GroupByTimeFillPlan groupByFillPlan, QueryContext context)
       throws QueryFilterOptimizationException, StorageEngineException, QueryProcessException,
           IOException {
-    GroupByEngineDataSet groupByEngineDataSet =
-        (GroupByEngineDataSet) groupBy(groupByFillPlan, context);
-    return new GroupByFillDataSet(
-        groupByFillPlan.getDeduplicatedPaths(),
-        groupByFillPlan.getDeduplicatedDataTypes(),
-        groupByEngineDataSet,
-        groupByFillPlan.getFillType(),
-        context,
-        groupByFillPlan);
+    //    if (logger.isDebugEnabled()) {
+    //      logger.debug(
+    //        "paths:"
+    //          + groupByFillPlan.getPaths()
+    //          + " level:"
+    //          + Arrays.toString(groupByFillPlan.getLevels()));
+    //    }

Review comment:
       ```suggestion
   
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org