You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@streams.apache.org by steveblackmon <gi...@git.apache.org> on 2017/01/04 00:37:14 UTC

[GitHub] incubator-streams pull request #346: Replace Guava API calls with Java 8 API

Github user steveblackmon commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/346#discussion_r94513265
  
    --- Diff: streams-contrib/streams-provider-facebook/src/main/java/org/apache/streams/facebook/provider/FacebookUserstreamProvider.java ---
    @@ -241,7 +240,7 @@ void shutdownAndAwaitTermination(ExecutorService pool) {
       @Override
       public void prepare(Object configurationObject) {
     
    -    executor = MoreExecutors.listeningDecorator(newFixedThreadPoolWithQueueSize(5, 20));
    +    executor = newFixedThreadPoolWithQueueSize(5, 20);
    --- End diff --
    
    I don't think we're going to be able to do this everywhere, but apparently it's ok in this provider if there's no compile error


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---