You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/20 10:25:27 UTC
[GitHub] [flink] snuyanzin opened a new pull request #17527: [docs] Add link from README.md to 'Building Flink from Source'
snuyanzin opened a new pull request #17527:
URL: https://github.com/apache/flink/pull/17527
## What is the purpose of the change
The PR suggest a link from `Building Apache Flink from Source` section of `README.md` file to the article https://nightlies.apache.org/flink/flink-docs-master/docs/flinkdev/building/ which contains more detailed info about building Flink
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17527: [docs] Add link from README.md to 'Building Flink from Source'
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17527:
URL: https://github.com/apache/flink/pull/17527#issuecomment-947536054
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit d65d5d3d68e46a5649d762c45a3b973602586607 (Wed Oct 20 10:28:47 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **Invalid pull request title: No valid Jira ID provided**
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17527: [hotfix][docs] Add link from README.md to 'Building Flink from Source'
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17527:
URL: https://github.com/apache/flink/pull/17527#issuecomment-947535485
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d65d5d3d68e46a5649d762c45a3b973602586607",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25270",
"triggerID" : "d65d5d3d68e46a5649d762c45a3b973602586607",
"triggerType" : "PUSH"
}, {
"hash" : "8d4e6f975a618204ad76907e1a275c3df18c0414",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25960",
"triggerID" : "8d4e6f975a618204ad76907e1a275c3df18c0414",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8d4e6f975a618204ad76907e1a275c3df18c0414 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25960)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17527: [hotfix][docs] Add link from README.md to 'Building Flink from Source'
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17527:
URL: https://github.com/apache/flink/pull/17527#issuecomment-947535485
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d65d5d3d68e46a5649d762c45a3b973602586607",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25270",
"triggerID" : "d65d5d3d68e46a5649d762c45a3b973602586607",
"triggerType" : "PUSH"
}, {
"hash" : "8d4e6f975a618204ad76907e1a275c3df18c0414",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8d4e6f975a618204ad76907e1a275c3df18c0414",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d65d5d3d68e46a5649d762c45a3b973602586607 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25270)
* 8d4e6f975a618204ad76907e1a275c3df18c0414 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17527: [hotfix][docs] Add link from README.md to 'Building Flink from Source'
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17527:
URL: https://github.com/apache/flink/pull/17527#issuecomment-947535485
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d65d5d3d68e46a5649d762c45a3b973602586607",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25270",
"triggerID" : "d65d5d3d68e46a5649d762c45a3b973602586607",
"triggerType" : "PUSH"
}, {
"hash" : "8d4e6f975a618204ad76907e1a275c3df18c0414",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25960",
"triggerID" : "8d4e6f975a618204ad76907e1a275c3df18c0414",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8d4e6f975a618204ad76907e1a275c3df18c0414 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25960)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17527: [docs] Add link from README.md to 'Building Flink from Source'
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17527:
URL: https://github.com/apache/flink/pull/17527#issuecomment-947535485
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d65d5d3d68e46a5649d762c45a3b973602586607",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d65d5d3d68e46a5649d762c45a3b973602586607",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d65d5d3d68e46a5649d762c45a3b973602586607 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17527: [hotfix][docs] Add link from README.md to 'Building Flink from Source'
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17527:
URL: https://github.com/apache/flink/pull/17527#issuecomment-947535485
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d65d5d3d68e46a5649d762c45a3b973602586607",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25270",
"triggerID" : "d65d5d3d68e46a5649d762c45a3b973602586607",
"triggerType" : "PUSH"
}, {
"hash" : "8d4e6f975a618204ad76907e1a275c3df18c0414",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25960",
"triggerID" : "8d4e6f975a618204ad76907e1a275c3df18c0414",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d65d5d3d68e46a5649d762c45a3b973602586607 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25270)
* 8d4e6f975a618204ad76907e1a275c3df18c0414 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25960)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17527: [hotfix][docs] Add link from README.md to 'Building Flink from Source'
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17527:
URL: https://github.com/apache/flink/pull/17527#issuecomment-947535485
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d65d5d3d68e46a5649d762c45a3b973602586607",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25270",
"triggerID" : "d65d5d3d68e46a5649d762c45a3b973602586607",
"triggerType" : "PUSH"
}, {
"hash" : "8d4e6f975a618204ad76907e1a275c3df18c0414",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25960",
"triggerID" : "8d4e6f975a618204ad76907e1a275c3df18c0414",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8d4e6f975a618204ad76907e1a275c3df18c0414 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25960)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #17527: [hotfix][docs] Add link from README.md to 'Building Flink from Source'
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #17527:
URL: https://github.com/apache/flink/pull/17527#issuecomment-979269318
@infoverload What's your opinion on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17527: [docs] Add link from README.md to 'Building Flink from Source'
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17527:
URL: https://github.com/apache/flink/pull/17527#issuecomment-947535485
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d65d5d3d68e46a5649d762c45a3b973602586607",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25270",
"triggerID" : "d65d5d3d68e46a5649d762c45a3b973602586607",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d65d5d3d68e46a5649d762c45a3b973602586607 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25270)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17527: [docs] Add link from README.md to 'Building Flink from Source'
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17527:
URL: https://github.com/apache/flink/pull/17527#issuecomment-947535485
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d65d5d3d68e46a5649d762c45a3b973602586607",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25270",
"triggerID" : "d65d5d3d68e46a5649d762c45a3b973602586607",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d65d5d3d68e46a5649d762c45a3b973602586607 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25270)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on pull request #17527: [hotfix][docs] Add link from README.md to 'Building Flink from Source'
Posted by GitBox <gi...@apache.org>.
snuyanzin commented on pull request #17527:
URL: https://github.com/apache/flink/pull/17527#issuecomment-976766385
Thanks for you feedback @MartijnVisser
I would agree with you if information from site is not available offline or is in a separate repo. However in fact both code and site content are in the same repository.
From one side yes, you are right, that being offline it is a bit tricky to open site, however from another side I know a header mentioned in README => I can do search by exact match across the repository I have downloaded (in case I don't know where to look for).
As far as I can see there is a whole Flink Development section at Flink site where it is described how to setup IDE (README also refers to that part of site) and lots hints which are not mentioned at README.
So it looks like being offline should not be an issue to find such info.
Probably the issue is that if we put a simple markdown link between README and docs from `docs` content then it will lead to https://github.com/apache/flink/blob/master/docs/content/docs/flinkDev/building.md which contains some `hugo` specific tags while https://nightlies.apache.org/flink/flink-docs-master/docs/flinkdev/building/ has the same info in a more human friendly rendered way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org