You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2023/02/09 19:52:05 UTC

[GitHub] [maven-compiler-plugin] gnodet commented on pull request #172: [MCOMPILER-525] - Incremental recompile incorrect detection of dependency change

gnodet commented on PR #172:
URL: https://github.com/apache/maven-compiler-plugin/pull/172#issuecomment-1424727847

   @jorsol I have a hard time understanding the exact change that fixes the problem.  Would it be possible to have a first commit that refactors the code using the nio api and other improvements, and another commit with the actual fix for the problem ?
   
   Note that we could also embeds [the trimmed down version](https://github.com/apache/maven-compiler-plugin/blob/7d9b2f7dbfd51d8400c332f6f50388d5a3eaf100/src/main/java/org/apache/maven/plugin/compiler/IncrementalBuildHelper.java) of the `IncrementalBuildHelper`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org