You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/08/23 12:46:36 UTC

[GitHub] [rocketmq-client-go] xujianhai666 commented on a change in pull request #174: [ISSUE #173]fix namesrv rr bug and remove extra code.

xujianhai666 commented on a change in pull request #174: [ISSUE #173]fix namesrv rr bug and remove extra code.
URL: https://github.com/apache/rocketmq-client-go/pull/174#discussion_r317114370
 
 

 ##########
 File path: internal/route.go
 ##########
 @@ -306,8 +306,8 @@ func (s *namesrvs) queryTopicRouteInfoFromServer(topic string) (*TopicRouteData,
 		rc := remote.NewRemotingCommand(ReqGetRouteInfoByTopic, request, nil)
 		response, err = s.nameSrvClient.InvokeSync(s.getNameServerAddress(), rc, requestTimeout)
 
-		if err != nil {
-			continue
+		if err == nil {
 
 Review comment:
   对比了java的效果, java目前的行为就是这样的. 同时，如果这么做的话，也一定程度上避免了线上同学的误操作带来的影响扩大

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services