You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by mashengchen <gi...@git.apache.org> on 2016/12/13 08:48:01 UTC
[GitHub] incubator-trafodion pull request #879: [TRAFODION-2211] trafci can use histo...
GitHub user mashengchen opened a pull request:
https://github.com/apache/incubator-trafodion/pull/879
[TRAFODION-2211] trafci can use history cmd
trafci should support up, down, left, right key in the keyboard
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mashengchen/incubator-trafodion trafci_his
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/879.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #879
----
commit 8618a51203e99a5075f3a3974d2c06b1ebdf1b60
Author: mashengchen <ma...@gmail.com>
Date: 2016-12-13T08:19:15Z
trafci can use history cmd
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #879: [TRAFODION-2211] trafci can use histo...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/879#discussion_r93284789
--- Diff: core/conn/trafci/installer_pom.xml ---
@@ -1,106 +1,112 @@
-<!--
- @@@ START COPYRIGHT @@@
-
- Licensed to the Apache Software Foundation (ASF) under one
- or more contributor license agreements. See the NOTICE file
- distributed with this work for additional information
- regarding copyright ownership. The ASF licenses this file
- to you under the Apache License, Version 2.0 (the
- "License"); you may not use this file except in compliance
- with the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing,
- software distributed under the License is distributed on an
- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- KIND, either express or implied. See the License for the
- specific language governing permissions and limitations
- under the License.
-
- @@@ END COPYRIGHT @@@
--->
+<!-- @@@ START COPYRIGHT @@@ Licensed to the Apache Software Foundation (ASF)
--- End diff --
Not sure what happened to the license text here. Could we put the original back?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #879: [TRAFODION-2211] trafci can use histo...
Posted by traflm <gi...@git.apache.org>.
Github user traflm commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/879#discussion_r92764647
--- Diff: core/conn/trafci/src/main/java/org/trafodion/ci/ConsoleReader.java ---
@@ -172,7 +176,8 @@ public String readLine() throws UnsupportedEncodingException, UserInterruption,
--- End diff --
This will remove Ctrl-C signal handler, did you test Ctrl-C in trafci? It should do a 'cancel query' if I remember it correctly. Anyway, you should make sure Ctrl-C has same behavior as before, should not be broken by this change.
I am not sure, need to check the trafci manual, but wondering if you have tested it or not? Since you comments out the signal handler.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #879: [TRAFODION-2211] trafci can use histo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/879
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #879: [TRAFODION-2211] trafci can use histo...
Posted by mashengchen <gi...@git.apache.org>.
Github user mashengchen commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/879#discussion_r92960037
--- Diff: core/conn/trafci/src/main/java/org/trafodion/ci/ConsoleReader.java ---
@@ -172,7 +176,8 @@ public String readLine() throws UnsupportedEncodingException, UserInterruption,
--- End diff --
ohh, i really not notice that.. i will research how to add this behavior.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #879: [TRAFODION-2211] trafci can use histo...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/879#discussion_r93285092
--- Diff: core/conn/trafci/src/main/resources/install_jar.xml ---
@@ -1,71 +1,64 @@
-<!--
- @@@ START COPYRIGHT @@@
-
- Licensed to the Apache Software Foundation (ASF) under one
- or more contributor license agreements. See the NOTICE file
- distributed with this work for additional information
- regarding copyright ownership. The ASF licenses this file
- to you under the Apache License, Version 2.0 (the
- "License"); you may not use this file except in compliance
- with the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing,
- software distributed under the License is distributed on an
- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- KIND, either express or implied. See the License for the
- specific language governing permissions and limitations
- under the License.
-
- @@@ END COPYRIGHT @@@
--->
+<!-- @@@ START COPYRIGHT @@@ Licensed to the Apache Software Foundation (ASF)
--- End diff --
Same comment about the license text.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---