You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2021/04/29 17:55:37 UTC
[GitHub] [drill] vvysotskyi opened a new pull request #2208: DRILL-7893: Column alias is not working for a parquet file
vvysotskyi opened a new pull request #2208:
URL: https://github.com/apache/drill/pull/2208
# [DRILL-7893](https://issues.apache.org/jira/browse/DRILL-7893): Column alias is not working for a parquet file
## Description
Updated visitors applied after optimizations to prevent creating unnecessary copies that will lose actual row type.
Added a call to create a top project after all optimizations to ensure that column names will match the name from row type.
## Documentation
NA
## Testing
Added unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] luocooong commented on pull request #2208: DRILL-7893: Column alias is not working for a parquet file
Posted by GitBox <gi...@apache.org>.
luocooong commented on pull request #2208:
URL: https://github.com/apache/drill/pull/2208#issuecomment-830087412
@paul-rogers Hello. Could you please help to do a review? thanks for your time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vvysotskyi commented on pull request #2208: DRILL-7893: Column alias is not working for a parquet file
Posted by GitBox <gi...@apache.org>.
vvysotskyi commented on pull request #2208:
URL: https://github.com/apache/drill/pull/2208#issuecomment-830798068
@luocooong, there is no need to test these changes in the distributed mode. Change in the final plan is minimal, it either creates an additional project if necessary or leaves the plan unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] luocooong merged pull request #2208: DRILL-7893: Column alias is not working for a parquet file
Posted by GitBox <gi...@apache.org>.
luocooong merged pull request #2208:
URL: https://github.com/apache/drill/pull/2208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] luocooong commented on pull request #2208: DRILL-7893: Column alias is not working for a parquet file
Posted by GitBox <gi...@apache.org>.
luocooong commented on pull request #2208:
URL: https://github.com/apache/drill/pull/2208#issuecomment-830794800
@vvysotskyi Hi. Have you tested these changes in a real world (distributed mode for better)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org