You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/10/05 19:55:14 UTC
[GitHub] [cloudstack] DaanHoogland opened a new pull request, #6797: proper storage construction
DaanHoogland opened a new pull request, #6797:
URL: https://github.com/apache/cloudstack/pull/6797
### Description
This PR Fixes: #6794
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #6797: new (java11) style storage construction
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #6797: new (java11) style storage construction
URL: https://github.com/apache/cloudstack/pull/6797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6797: proper storage construction
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6797:
URL: https://github.com/apache/cloudstack/pull/6797#issuecomment-1334960845
this has become stale but the change is in line with java deprecation lines, so changing the title and re-testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #6797: new (java11) style storage construction
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #6797:
URL: https://github.com/apache/cloudstack/pull/6797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6797: proper storage construction
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6797:
URL: https://github.com/apache/cloudstack/pull/6797#issuecomment-1264691744
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6797?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6797](https://codecov.io/gh/apache/cloudstack/pull/6797?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50d925b) into [main](https://codecov.io/gh/apache/cloudstack/commit/89d9a70dcebf2b1b94a56d5dcb9e1b43ed538c95?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (89d9a70) will **increase** coverage by `0.19%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## main #6797 +/- ##
============================================
+ Coverage 10.33% 10.52% +0.19%
- Complexity 6608 6787 +179
============================================
Files 2451 2464 +13
Lines 242340 244169 +1829
Branches 37924 38205 +281
============================================
+ Hits 25054 25709 +655
- Misses 214200 215225 +1025
- Partials 3086 3235 +149
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6797?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../hypervisor/kvm/storage/KVMStoragePoolManager.java](https://codecov.io/gh/apache/cloudstack/pull/6797/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vc3RvcmFnZS9LVk1TdG9yYWdlUG9vbE1hbmFnZXIuamF2YQ==) | `0.48% <0.00%> (-0.01%)` | :arrow_down: |
| [.../cloudstack/api/response/ApiDiscoveryResponse.java](https://codecov.io/gh/apache/cloudstack/pull/6797/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hcGkvZGlzY292ZXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL2FwaS9yZXNwb25zZS9BcGlEaXNjb3ZlcnlSZXNwb25zZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../cloudstack/api/response/ApiParameterResponse.java](https://codecov.io/gh/apache/cloudstack/pull/6797/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hcGkvZGlzY292ZXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL2FwaS9yZXNwb25zZS9BcGlQYXJhbWV0ZXJSZXNwb25zZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...e/cloudstack/api/response/ApiResponseResponse.java](https://codecov.io/gh/apache/cloudstack/pull/6797/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hcGkvZGlzY292ZXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL2FwaS9yZXNwb25zZS9BcGlSZXNwb25zZVJlc3BvbnNlLmphdmE=) | `0.00% <0.00%> (-80.00%)` | :arrow_down: |
| [.../cloudstack/discovery/ApiDiscoveryServiceImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6797/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hcGkvZGlzY292ZXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL2Rpc2NvdmVyeS9BcGlEaXNjb3ZlcnlTZXJ2aWNlSW1wbC5qYXZh) | `13.93% <0.00%> (-55.25%)` | :arrow_down: |
| [...rce/wrapper/LibvirtResizeVolumeCommandWrapper.java](https://codecov.io/gh/apache/cloudstack/pull/6797/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2Uvd3JhcHBlci9MaWJ2aXJ0UmVzaXplVm9sdW1lQ29tbWFuZFdyYXBwZXIuamF2YQ==) | `49.50% <0.00%> (-27.17%)` | :arrow_down: |
| [...rc/main/java/com/cloud/storage/StorageManager.java](https://codecov.io/gh/apache/cloudstack/pull/6797/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL2NvbXBvbmVudHMtYXBpL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3N0b3JhZ2UvU3RvcmFnZU1hbmFnZXIuamF2YQ==) | `76.92% <0.00%> (-23.08%)` | :arrow_down: |
| [.../cloud/hypervisor/kvm/storage/KVMPhysicalDisk.java](https://codecov.io/gh/apache/cloudstack/pull/6797/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vc3RvcmFnZS9LVk1QaHlzaWNhbERpc2suamF2YQ==) | `70.27% <0.00%> (-10.98%)` | :arrow_down: |
| [...pper/LibvirtPrepareForMigrationCommandWrapper.java](https://codecov.io/gh/apache/cloudstack/pull/6797/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2Uvd3JhcHBlci9MaWJ2aXJ0UHJlcGFyZUZvck1pZ3JhdGlvbkNvbW1hbmRXcmFwcGVyLmphdmE=) | `43.10% <0.00%> (-10.09%)` | :arrow_down: |
| [.../cloudstack/ratelimit/ApiRateLimitServiceImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6797/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hcGkvcmF0ZS1saW1pdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9yYXRlbGltaXQvQXBpUmF0ZUxpbWl0U2VydmljZUltcGwuamF2YQ==) | `68.88% <0.00%> (-4.45%)` | :arrow_down: |
| ... and [152 more](https://codecov.io/gh/apache/cloudstack/pull/6797/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6797: new (java11) style storage construction
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6797:
URL: https://github.com/apache/cloudstack/pull/6797#issuecomment-1637584292
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6797: proper storage construction
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6797:
URL: https://github.com/apache/cloudstack/pull/6797#issuecomment-1264945364
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6797: new (java11) style storage construction
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6797:
URL: https://github.com/apache/cloudstack/pull/6797#issuecomment-1637516451
@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6797: new (java11) style storage construction
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6797:
URL: https://github.com/apache/cloudstack/pull/6797#issuecomment-1639760984
@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6797: proper storage construction
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6797:
URL: https://github.com/apache/cloudstack/pull/6797#issuecomment-1264945850
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6797: proper storage construction
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #6797:
URL: https://github.com/apache/cloudstack/pull/6797#discussion_r991603961
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStoragePoolManager.java:
##########
@@ -113,7 +113,8 @@ public KVMStoragePoolManager(StorageLayer storagelayer, KVMHAMonitor monitor) {
s_logger.warn(String.format("Duplicate StorageAdaptor type %s, not loading %s", info.storagePoolType().toString(), storageAdaptor.getName()));
} else {
try {
- this._storageMapper.put(info.storagePoolType().toString(), storageAdaptor.newInstance());
+ s_logger.info(String.format("adding storage adaptor for %s", storageAdaptor.getName()));
+ this._storageMapper.put(info.storagePoolType().toString(), storageAdaptor.getDeclaredConstructor().newInstance());
Review Comment:
`getDeclaredConstructor().newInstance()` does the same as `newInstance()` but in a non-deprecated way. I haven´t figured it out yet, but I don´t think this will solve the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6797: new (java11) style storage construction
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6797:
URL: https://github.com/apache/cloudstack/pull/6797#issuecomment-1641005594
<b>[SF] Trillian test result (tid-7103)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44527 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6797-t7103-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_migrate_VM_and_root_volume | `Error` | 75.58 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 53.35 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6797: new (java11) style storage construction
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #6797:
URL: https://github.com/apache/cloudstack/pull/6797#issuecomment-1637515523
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6797: new (java11) style storage construction
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #6797:
URL: https://github.com/apache/cloudstack/pull/6797#issuecomment-1639759588
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6797: proper storage construction
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6797:
URL: https://github.com/apache/cloudstack/pull/6797#issuecomment-1264973599
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org