[GitHub] [airflow] ephraimbuddy commented on pull request #17207: WIP: Fix external_executor_id not being set for manually run jobs.

[GitBox <gi...@apache.org>]

ephraimbuddy commented on pull request #17207:
URL: https://github.com/apache/airflow/pull/17207#issuecomment-901928314


   > > I feel we should not make this change but dig more to reliably reproduce the linked issue.
   > > On my first try, I was able to see `Scheduler marked as failed` but on several tries now, I can't reproduce it. I ended up having task stuck in running which is related to another issue(Trying to find how I got to that)
   > 
   > First of all, thanks for taking a look at the PR!
   > 
   > There are a couple things that need to hold for you to be able to reproduce it:
   > 
   > * Before starting the task, the task should not have run before or at least the `external_executor_id` must be None.
   > * The task must still be running when the adoption flow of one of the schedulers kicks in.
   > 
   > I am able to reliable reproduce this issue when these two things are held.
   > 
   > However, I am not really sure what you mean with dig deeper. Unless the whole executor part is rewritten, this is the best I could come up with. Could you please be a bit more explicit?
   
   I did reproduce it initially but can't reproduce it again. Have done `airflow db reset` in `breeze` but can't reproduce it. Well, I do not fully understand this area, let's hear from others


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org