[GitHub] [arrow] nealrichardson commented on a diff in pull request #35055: GH-34436: [R] Bindings for JSON Dataset

["nealrichardson (via GitHub)" <gi...@apache.org>]

nealrichardson commented on code in PR #35055:
URL: https://github.com/apache/arrow/pull/35055#discussion_r1200396889


##########
r/R/dataset-format.R:
##########
@@ -532,6 +565,22 @@ ParquetFragmentScanOptions$create <- function(use_buffered_stream = FALSE,
   dataset___ParquetFragmentScanOptions__Make(use_buffered_stream, buffer_size, pre_buffer)
 }
 
+#' @usage NULL
+#' @format NULL
+#' @rdname FragmentScanOptions
+#' @export
+JsonFragmentScanOptions <- R6Class("JsonFragmentScanOptions", inherit = FragmentScanOptions)

Review Comment:
   No, it's fine, Acero needs these too, not just the old Scanner.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org