You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by GitBox <gi...@apache.org> on 2022/08/18 21:20:06 UTC
[GitHub] [samza-hello-samza] james-deee opened a new pull request, #87: Upgrade hello-samza to latest deps and prepare for Java 11
james-deee opened a new pull request, #87:
URL: https://github.com/apache/samza-hello-samza/pull/87
This is preparing things so that this app will work with Java 11. Once this Samza app PR is merged and released, we can update this to use the that version in the pom.xml file.
I am also deleting the gradle artifacts because this whole project is actually using Maven (not gradle, which was version 2 or something).
Verified that these version bumps (including the use of Scala 2.12 from Samza) all work. Note this moves Hadoop to be a Java 11 compatible version as well.
I have also tested with my local build from the Samza PR above, and using Java 11 that all of this works as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@samza.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza-hello-samza] malcolm-pro commented on a diff in pull request #87: SAMZA-2757 : Make Samza Compatible with Java 11
Posted by "malcolm-pro (via GitHub)" <gi...@apache.org>.
malcolm-pro commented on code in PR #87:
URL: https://github.com/apache/samza-hello-samza/pull/87#discussion_r1187747914
##########
bin/grid:
##########
@@ -34,9 +34,10 @@ DEPLOY_ROOT_DIR=$BASE_DIR/deploy
DOWNLOAD_CACHE_DIR=$HOME/.samza/download
COMMAND=$1
SYSTEM=$2
+YARN_VERSION="3.3.4"
Review Comment:
Should this be flagged somehow to correspond with the version of Java being used, or maybe intentionally flagged? I believe Samza under Java 8 is still using Hadoop 2.10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@samza.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza-hello-samza] james-deee commented on a diff in pull request #87: SAMZA-2757 : Make Samza Compatible with Java 11
Posted by "james-deee (via GitHub)" <gi...@apache.org>.
james-deee commented on code in PR #87:
URL: https://github.com/apache/samza-hello-samza/pull/87#discussion_r1187765470
##########
bin/grid:
##########
@@ -34,9 +34,10 @@ DEPLOY_ROOT_DIR=$BASE_DIR/deploy
DOWNLOAD_CACHE_DIR=$HOME/.samza/download
COMMAND=$1
SYSTEM=$2
+YARN_VERSION="3.3.4"
Review Comment:
I confirmed that using Java8 still works with this setup (meaning 3.3.4). So this whole system still works if you are running Java 8, It's just that this newer setup (if you use Samza 1.8.0) now works with Java 11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@samza.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org