You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Jefffrey (via GitHub)" <gi...@apache.org> on 2023/02/11 09:53:05 UTC
[GitHub] [arrow-datafusion] Jefffrey opened a new pull request, #5249: Disallow SORT BY in SQL
Jefffrey opened a new pull request, #5249:
URL: https://github.com/apache/arrow-datafusion/pull/5249
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #5247
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
No tests added. Adding tests for invalid SQL might not be desirable (considering potential surface area of invalid SQL)
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5249: Disallow SORT BY in SQL
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5249:
URL: https://github.com/apache/arrow-datafusion/pull/5249#issuecomment-1426768667
Here is a proposed test: https://github.com/apache/arrow-datafusion/pull/5254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5249: Disallow SORT BY in SQL
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #5249:
URL: https://github.com/apache/arrow-datafusion/pull/5249#discussion_r1103622817
##########
datafusion/sql/src/select.rs:
##########
@@ -59,6 +59,9 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
if select.top.is_some() {
return Err(DataFusionError::NotImplemented("TOP".to_string()));
}
+ if !select.sort_by.is_empty() {
Review Comment:
👍
It would be nice to add a .slt test for this case, but I also think it is ok not to
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5249: Disallow SORT BY in SQL
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5249:
URL: https://github.com/apache/arrow-datafusion/pull/5249#issuecomment-1426770657
Benchmark runs are scheduled for baseline = 8719041ff9ad20df451267c04b0c7b73f1a0d064 and contender = ec9119d9d7fe6481a71b5ec213f07eed55ad0357. ec9119d9d7fe6481a71b5ec213f07eed55ad0357 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b01130d40d9c4fb59f5d129bd211b845...8c0a4f5af9124389a9230b9863af7ec5/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3284fad457f042a7afd1e2343cfd9025...e2f58c7f89fc410aac9755e6158a6246/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/99a2c535c1fe4e62a4c21297f30825c4...42efc9b3a661477686371d464abe5fe6/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/f54d78ddbda940209099ac056b122b5c...7f1fa359ed664daa93a6e67d835d3820/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5249: Disallow SORT BY in SQL
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5249:
URL: https://github.com/apache/arrow-datafusion/pull/5249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org