You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/08/26 10:26:27 UTC
[GitHub] [ratis] adoroszlai opened a new pull request, #725: RATIS-1687. Make SetConfigurationRequest backwards compatible
adoroszlai opened a new pull request, #725:
URL: https://github.com/apache/ratis/pull/725
## What changes were proposed in this pull request?
Changes made to SetConfigurationRequest for RATIS-1593 and RATIS-1594 are not backwards compatible. Downstream component (e.g. Ozone) needs code change to be able to construct a SetConfigurationRequest after upgrade. I think we should support the old interface for 2.4.0.
https://issues.apache.org/jira/browse/RATIS-1687
## How was this patch tested?
Built Ratis, compiled Ozone with it.
Regular CI:
https://github.com/adoroszlai/incubator-ratis/actions/runs/2929301261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] adoroszlai commented on pull request #725: RATIS-1687. Make SetConfigurationRequest backwards compatible
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #725:
URL: https://github.com/apache/ratis/pull/725#issuecomment-1228681636
> Thanks for help test 2.4.0-rc0, are there any other issues in the process of testing 2.4.0-rc0 with ozone?
@codings-dan So far I've only found [RATIS-1691](https://issues.apache.org/jira/browse/RATIS-1691) in addition to this one. Currently running Ozone integration tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] codings-dan commented on pull request #725: RATIS-1687. Make SetConfigurationRequest backwards compatible
Posted by GitBox <gi...@apache.org>.
codings-dan commented on PR #725:
URL: https://github.com/apache/ratis/pull/725#issuecomment-1228620353
@adoroszlai Thanks for help test 2.4.0-rc0, are there any other issues in the process of testing 2.4.0-rc0 with ozone? We can launch 2.4.0-rc1 after all known issues are resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo merged pull request #725: RATIS-1687. Make SetConfigurationRequest backwards compatible
Posted by GitBox <gi...@apache.org>.
szetszwo merged PR #725:
URL: https://github.com/apache/ratis/pull/725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] adoroszlai commented on pull request #725: RATIS-1687. Make SetConfigurationRequest backwards compatible
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #725:
URL: https://github.com/apache/ratis/pull/725#issuecomment-1228714643
Thanks @codings-dan for the review, @szetszwo for reviewing and merging it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org