You are viewing a plain text version of this content. The canonical link for it is here.

Posted to hdfs-issues@hadoop.apache.org by "Eli Collins (JIRA)" <ji...@apache.org> on 2013/01/08 23:42:13 UTC

[jira] [Updated] (HDFS-4034) Remove redundant null checks

     [ https://issues.apache.org/jira/browse/HDFS-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins updated HDFS-4034:
------------------------------

          Resolution: Fixed
       Fix Version/s: 2.0.3-alpha
    Target Version/s:   (was: 2.0.3-alpha)
        Hadoop Flags: Reviewed
              Status: Resolved  (was: Patch Available)

Thanks for the review ATM. I've committed this and merged to branch-2.
                
> Remove redundant null checks
> ----------------------------
>
>                 Key: HDFS-4034
>                 URL: https://issues.apache.org/jira/browse/HDFS-4034
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>             Fix For: 2.0.3-alpha
>
>         Attachments: hdfs-4034.txt, hdfs-4034.txt
>
>
> Findbugs 2 catches a number of places where we're checking for null in cases where the value will never be null.
> We might need to wait until we switch to findbugs 2 to commit this as the current findbugs may not be so smart.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira