You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2023/01/15 22:00:57 UTC
[GitHub] [netbeans] lkishalmi opened a new pull request, #5297: Minimal Lexing Support for Go Language
lkishalmi opened a new pull request, #5297:
URL: https://github.com/apache/netbeans/pull/5297
Well, this one is based on #5287.
I'd keep that PR separate from this, when that merged, I'd rebase this one and squash before merging.
Other than that. this is just provides simple syntax highlight for Go files, with Editor preferences.
I may able to add parser based error hints, which can be useful, maybe folding and navigatior support could be theoretically easy to be added, however not necessary for NB17.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #5297: Minimal Lexing Support for Go Language
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on PR #5297:
URL: https://github.com/apache/netbeans/pull/5297#issuecomment-1384219976
Well, this one is just a showcase of my two new modules `lexer.antlr4` and `go.lang` for NB17.
AFAIK, Textmate based Syntax-highlight, provides:
- File icon/type association
- Syntax highlight
This one provides:
- File icon/type association
- Syntax highlight
- Custom Editor Preferences for Go File: Highlighting, Formatting
- Minimal Parser based error highlight.
- Code Folding
I never tried to use a Go LSP, I'm not really interested in that or in the Go language. I just need Go for my upcoming Terraform works,but for that the parser is enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #5297: Minimal Lexing Support for Go Language
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on PR #5297:
URL: https://github.com/apache/netbeans/pull/5297#issuecomment-1383501823
Technically, it wouldn't be too hard to add navigator support to this. Later on if someone interested, could implement getting proper information from the parser. Even a full language support could be achievable. Unfortunately, I feel disgust when I see a Go code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #5297: Minimal Lexing Support for Go Language
Posted by GitBox <gi...@apache.org>.
Chris2011 commented on PR #5297:
URL: https://github.com/apache/netbeans/pull/5297#issuecomment-1384318922
I'm fine with this. I also think that ANTLR has more powerful options, problematic, what I think is kind of complex for beginners. At the end, mine is just a collection of those languages, @lkishalmi is direct inside of the core so we have a bit more options afaik. I would also say that we don't need more than two optiosn to add a new language. Antlr and textmate + lsp is fine if we have good resources for new comers to show them how to implement syntax highlighting, code completion (also context based), hints, formatting, code folding, etc. My two cents.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a diff in pull request #5297: Minimal Lexing Support for Go Language
Posted by "lkishalmi (via GitHub)" <gi...@apache.org>.
lkishalmi commented on code in PR #5297:
URL: https://github.com/apache/netbeans/pull/5297#discussion_r1103485544
##########
nbbuild/rat-exclusions.txt:
##########
@@ -220,6 +220,7 @@ javafx/javafx2.project/src/org/netbeans/modules/javafx2/project/templates/**
java/jshell.support/src/org/netbeans/modules/jshell/resources/consoleExample.jsh
java/junit.ui/src/org/netbeans/modules/junit/ui/resources/*.template
ide/languages.diff/src/org/netbeans/modules/languages/diff/DiffExample.diff
+ide/languages.go/src/org/netbeans/modules/languages/go/*.go
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a diff in pull request #5297: Minimal Lexing Support for Go Language
Posted by "lkishalmi (via GitHub)" <gi...@apache.org>.
lkishalmi commented on code in PR #5297:
URL: https://github.com/apache/netbeans/pull/5297#discussion_r1084551281
##########
ide/languages.go/licenseinfo.xml:
##########
@@ -0,0 +1,27 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<licenseinfo>
+ <fileset>
+ <file>src/org/netbeans/modules/languages/go/resources/go-blue.png</file>
+ <license ref="CC-BY-4.0" />
Review Comment:
@matthiasblaesing I've just re-read the license and the ASF 3rd Party License policy. It seems the best would be to create an icon of our own.
The main issue I see here, is that this image is modified (resized) work, in which case we should abide to the share-alike clause, which we can't do in ASF. Unmodified work could be included. I've tried to use the original SVG, but NetBeans does not like that one.
Unfortunately, I'm really clumsy with graphics stuff, other than resizing. The TOML file icon is about my limit. So I'd be happy if you could type that 2 letters. (A 16x16 PNG is needed with transparent background) I think the selected blue would fit both light and dark LaF-s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a diff in pull request #5297: Minimal Lexing Support for Go Language
Posted by "lkishalmi (via GitHub)" <gi...@apache.org>.
lkishalmi commented on code in PR #5297:
URL: https://github.com/apache/netbeans/pull/5297#discussion_r1103485495
##########
ide/languages.go/licenseinfo.xml:
##########
@@ -0,0 +1,27 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<licenseinfo>
+ <fileset>
+ <file>src/org/netbeans/modules/languages/go/resources/go-blue.png</file>
+ <license ref="CC-BY-4.0" />
Review Comment:
@matthiasblaesing Thanks for the commits. I really appreciate them!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a diff in pull request #5297: Minimal Lexing Support for Go Language
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on code in PR #5297:
URL: https://github.com/apache/netbeans/pull/5297#discussion_r1095102165
##########
ide/languages.go/licenseinfo.xml:
##########
@@ -0,0 +1,27 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<licenseinfo>
+ <fileset>
+ <file>src/org/netbeans/modules/languages/go/resources/go-blue.png</file>
+ <license ref="CC-BY-4.0" />
Review Comment:
Done: https://github.com/matthiasblaesing/netbeans/commit/437391c84b3178ee5533488e1a98c56a88633224
I documented how the "logo" was created in the SVG.
I noticed a warning when starting (registration of GoLanguage collides with antlr3 grammar one). This is my fix:
https://github.com/matthiasblaesing/netbeans/commit/50955a9a8a71dfac214be650ae69b5adda147f2c
Feel free to pull changes from https://github.com/matthiasblaesing/netbeans/commits/pr-5297 and squash them into your work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5297: Minimal Lexing Support for Go Language
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #5297:
URL: https://github.com/apache/netbeans/pull/5297#issuecomment-1384153329
Don't feel best placed to review this. What are the pros / cons of this approach vs the syntax highlighting support listed in @Chris2011 list (https://github.com/Chris2011/netbeans-textmate-files) with / without an LSP server? I have mixed feelings about how much we provide minimal language support in a specific vs generic way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a diff in pull request #5297: Minimal Lexing Support for Go Language
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on code in PR #5297:
URL: https://github.com/apache/netbeans/pull/5297#discussion_r1071494932
##########
nbbuild/licenses/CC-BY-4.0:
##########
@@ -0,0 +1,429 @@
+Attribution-ShareAlike 4.0 International
Review Comment:
This is `CC-BY-SA-4.0`. Given the wording of the license in the attribution clause, this needs an entry in the notice section.
##########
nbbuild/rat-exclusions.txt:
##########
@@ -220,6 +220,7 @@ javafx/javafx2.project/src/org/netbeans/modules/javafx2/project/templates/**
java/jshell.support/src/org/netbeans/modules/jshell/resources/consoleExample.jsh
java/junit.ui/src/org/netbeans/modules/junit/ui/resources/*.template
ide/languages.diff/src/org/netbeans/modules/languages/diff/DiffExample.diff
+ide/languages.go/src/org/netbeans/modules/languages/go/*.go
Review Comment:
Please use the `licenseinfo.xml` to declare `GoExample.go` as `Apache-2.0-ASF`.
##########
ide/languages.go/nbproject/project.properties:
##########
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+javac.source=1.8
+
+# As of 2nd Jan 2023, we use the Grammar from:
+# https://github.com/antlr/grammars-v4/tree/4794c0c5371ce6b0711a306256f8f7706394ec6d/golang
+#
+golang.grammar.version=4794c0c5371ce6b0711a306256f8f7706394ec6d
Review Comment:
This is not needed or is it? But it reminds me, that parsers have the tendency to create incompatible code when the grammar is modified. So either `go.lang` should be a friend-only export or we must be willing to drop compatibility in the future (i.e. raise major version).
##########
ide/languages.go/licenseinfo.xml:
##########
@@ -0,0 +1,27 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<licenseinfo>
+ <fileset>
+ <file>src/org/netbeans/modules/languages/go/resources/go-blue.png</file>
+ <license ref="CC-BY-4.0" />
Review Comment:
As written below I find this problematic. This is missing the required attribution from CC-BY-SA-4.0.
I assume the logo was taken from the go lang repository. Wikimedia Commons holds a PD licensed copy: https://commons.wikimedia.org/wiki/File:Go_Logo_Blue.svg
If that is not acceptable, I'm willing to open my graphic programm and enter the two letters and choose the "right" color.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #5297: Minimal Lexing Support for Go Language
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on PR #5297:
URL: https://github.com/apache/netbeans/pull/5297#issuecomment-1385633420
Well, the workweek has started for me. @matthiasblaesing pointed out valid things on the Licensing part. Thanks again for your wisdom!
I moved the milestone to NB18, to give less headache to @neilcsmith-net when he cuts the release branch for NB17.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5297: Minimal Lexing Support for Go Language
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5297:
URL: https://github.com/apache/netbeans/pull/5297#issuecomment-1414404751
created a https://github.com/apache/netbeans/labels/Go label. Since something tells me this won't be the last Go PR :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #5297: Minimal Lexing Support for Go Language
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on PR #5297:
URL: https://github.com/apache/netbeans/pull/5297#issuecomment-1383385607
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a diff in pull request #5297: Minimal Lexing Support for Go Language
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on code in PR #5297:
URL: https://github.com/apache/netbeans/pull/5297#discussion_r1071574834
##########
ide/languages.go/licenseinfo.xml:
##########
@@ -0,0 +1,27 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<licenseinfo>
+ <fileset>
+ <file>src/org/netbeans/modules/languages/go/resources/go-blue.png</file>
+ <license ref="CC-BY-4.0" />
Review Comment:
Well it's a scaled down version the one in the bundle at: https://blog.golang.org/go-brand
The site says:
> Like this blog and all our gopher images, the slide themes are Creative Commons Attribution 4.0 licensed.
The zip contains a `copyright.txt` with the content:
> All content within this zip file is Copyright 2018 The Go Authors. All rights reserved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a diff in pull request #5297: Minimal Lexing Support for Go Language
Posted by "lkishalmi (via GitHub)" <gi...@apache.org>.
lkishalmi commented on code in PR #5297:
URL: https://github.com/apache/netbeans/pull/5297#discussion_r1103485366
##########
ide/languages.go/nbproject/project.properties:
##########
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+javac.source=1.8
+
+# As of 2nd Jan 2023, we use the Grammar from:
+# https://github.com/antlr/grammars-v4/tree/4794c0c5371ce6b0711a306256f8f7706394ec6d/golang
+#
+golang.grammar.version=4794c0c5371ce6b0711a306256f8f7706394ec6d
Review Comment:
I know it's a bit controversial topic nowadays, but I'd rather raise the release version on the go.lang module if needed.
Though I removed this stuff from here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a diff in pull request #5297: Minimal Lexing Support for Go Language
Posted by "lkishalmi (via GitHub)" <gi...@apache.org>.
lkishalmi commented on code in PR #5297:
URL: https://github.com/apache/netbeans/pull/5297#discussion_r1103485606
##########
nbbuild/licenses/CC-BY-4.0:
##########
@@ -0,0 +1,429 @@
+Attribution-ShareAlike 4.0 International
Review Comment:
At the end I've removed the CC-BY-SA-4.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi merged pull request #5297: Minimal Lexing Support for Go Language
Posted by "lkishalmi (via GitHub)" <gi...@apache.org>.
lkishalmi merged PR #5297:
URL: https://github.com/apache/netbeans/pull/5297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists