You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by adzellman <gi...@git.apache.org> on 2016/10/05 22:20:44 UTC
[GitHub] cordova-ios pull request #263: CB-11952 - Introduce buildFlag option
GitHub user adzellman opened a pull request:
https://github.com/apache/cordova-ios/pull/263
CB-11952 - Introduce buildFlag option
### Platforms affected
iOS
### What does this PR do?
- Add buildFlag option for passing args to xcodebuild
- There can be multiple --buildFlag declarations
- Warns if buildFlag would override a built-in setting
### What testing has been done on this change?
I have tried this out with by passing various legal and illegal flags using the --buildFlag option. I used the [xcodebuild man page](https://developer.apple.com/legacy/library/documentation/Darwin/Reference/ManPages/man1/xcodebuild.1.html) to develop test cases.
### Checklist
- [] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/adzellman/aemm-ios CB-11952
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/263.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #263
----
commit dcbcaa466a3240eb277a5fcbd0691f18c21d3326
Author: Andrew Zellman <ze...@adobe.com>
Date: 2016-10-05T22:14:59Z
CB-11952 - Introduce buildFlag option
- Allows user to pass arguments to xcodebuild
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #263: CB-11952 - Introduce buildFlag option
Posted by adzellman <gi...@git.apache.org>.
Github user adzellman commented on the issue:
https://github.com/apache/cordova-ios/pull/263
I'm going to clean this up and submit a new PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request #263: CB-11952 - Introduce buildFlag option
Posted by adzellman <gi...@git.apache.org>.
Github user adzellman closed the pull request at:
https://github.com/apache/cordova-ios/pull/263
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #263: CB-11952 - Introduce buildFlag option
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/263
## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/263?src=pr) is 54.46% (diff: 0.00%)
> Merging [#263](https://codecov.io/gh/apache/cordova-ios/pull/263?src=pr) into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr) will decrease coverage by **2.03%**
```diff
@@ master #263 diff @@
==========================================
Files 12 12
Lines 1230 1276 +46
Methods 198 200 +2
Messages 0 0
Branches 193 216 +23
==========================================
Hits 695 695
- Misses 535 581 +46
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [636113f...9a95a72](https://codecov.io/gh/apache/cordova-ios/compare/636113f047ee2c7dae742dff2beafae2121ceb62...9a95a72106454e78725d92efd58267e3df79a820?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #263: CB-11952 - Introduce buildFlag option
Posted by adzellman <gi...@git.apache.org>.
Github user adzellman commented on the issue:
https://github.com/apache/cordova-ios/pull/263
Let me see if I can add some tests here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org