You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Suresh Srinivas (JIRA)" <ji...@apache.org> on 2009/05/14 18:58:46 UTC
[jira] Created: (HADOOP-5835) Fix findbugs warnings
Fix findbugs warnings
---------------------
Key: HADOOP-5835
URL: https://issues.apache.org/jira/browse/HADOOP-5835
Project: Hadoop Core
Issue Type: Bug
Reporter: Suresh Srinivas
Assignee: Suresh Srinivas
Cleaning up findbugs warnings for some of the files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5835) Fix findbugs warnings
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-5835:
------------------------------------
Attachment: findbugs.patch
Attaching the right file
> Fix findbugs warnings
> ---------------------
>
> Key: HADOOP-5835
> URL: https://issues.apache.org/jira/browse/HADOOP-5835
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: findbugs.patch, findbugs.patch, findbugs.patch
>
>
> Cleaning up findbugs warnings for some of the files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5835) Fix findbugs warnings
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710569#action_12710569 ]
Suresh Srinivas commented on HADOOP-5835:
-----------------------------------------
Passed unit tests as well
> Fix findbugs warnings
> ---------------------
>
> Key: HADOOP-5835
> URL: https://issues.apache.org/jira/browse/HADOOP-5835
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: findbugs.patch, findbugs.patch, findbugs.patch
>
>
> Cleaning up findbugs warnings for some of the files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5835) Fix findbugs warnings
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-5835:
-------------------------------------------
Component/s: dfs
Hadoop Flags: [Reviewed]
+1 patch looks good.
> Fix findbugs warnings
> ---------------------
>
> Key: HADOOP-5835
> URL: https://issues.apache.org/jira/browse/HADOOP-5835
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: findbugs.patch, findbugs.patch, findbugs.patch
>
>
> Cleaning up findbugs warnings for some of the files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5835) Fix findbugs warnings
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-5835:
------------------------------------
Attachment: findbugs.patch
Warnings fixed:
# org.apache.hadoop.hdfs.server.protocol.BlockMetaDataInfo doesn't override org.apache.hadoop.hdfs.protocol.Block.equals(Object)
# org.apache.hadoop.hdfs.server.protocol.DatanodeRegistration doesn't override org.apache.hadoop.hdfs.protocol.DatanodeID.equals(Object)
# Write to static field org.apache.hadoop.hdfs.server.datanode.DataNode.datanodeObject from instance method new org.apache.hadoop.hdfs.server.datanode.DataNode(Configuration, AbstractList?)
# Write to static field org.apache.hadoop.hdfs.server.datanode.DataNode.nameNodeAddr from instance method org.apache.hadoop.hdfs.server.datanode.DataNode.startDataNode(Configuration, AbstractList?)
# Write to static field org.apache.hadoop.hdfs.server.namenode.NameNode.myMetrics from instance method org.apache.hadoop.hdfs.server.namenode.NameNode.initialize(Configuration)
Changes:
# Added {{equals}} method implementation
# Made Namenode constructor protected so that {{createNameNode}} methods are the only way to create namenode. Initializing static variables using a static method.
# Made Datanode constructor protected so that {{makeInstance}} method is the only way to create datanode. Initializing static variables using a static method.
> Fix findbugs warnings
> ---------------------
>
> Key: HADOOP-5835
> URL: https://issues.apache.org/jira/browse/HADOOP-5835
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: findbugs.patch
>
>
> Cleaning up findbugs warnings for some of the files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5835) Fix findbugs warnings
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-5835:
-------------------------------------------
Resolution: Fixed
Fix Version/s: 0.21.0
Status: Resolved (was: Patch Available)
I have committed this. Thanks, Suresh!
> Fix findbugs warnings
> ---------------------
>
> Key: HADOOP-5835
> URL: https://issues.apache.org/jira/browse/HADOOP-5835
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.21.0
>
> Attachments: findbugs.patch, findbugs.patch, findbugs.patch
>
>
> Cleaning up findbugs warnings for some of the files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5835) Fix findbugs warnings
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-5835:
------------------------------------
Status: Patch Available (was: Open)
> Fix findbugs warnings
> ---------------------
>
> Key: HADOOP-5835
> URL: https://issues.apache.org/jira/browse/HADOOP-5835
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: findbugs.patch
>
>
> Cleaning up findbugs warnings for some of the files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5835) Fix findbugs warnings
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710507#action_12710507 ]
Suresh Srinivas commented on HADOOP-5835:
-----------------------------------------
Here is the test-patch result. No tests added because this is findbugs warning cleanup.
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
> Fix findbugs warnings
> ---------------------
>
> Key: HADOOP-5835
> URL: https://issues.apache.org/jira/browse/HADOOP-5835
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: findbugs.patch, findbugs.patch, findbugs.patch
>
>
> Cleaning up findbugs warnings for some of the files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5835) Fix findbugs warnings
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-5835:
------------------------------------
Attachment: findbugs.patch
New patch to restrict changes only to fix findbugs warnings
> Fix findbugs warnings
> ---------------------
>
> Key: HADOOP-5835
> URL: https://issues.apache.org/jira/browse/HADOOP-5835
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: findbugs.patch, findbugs.patch
>
>
> Cleaning up findbugs warnings for some of the files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.